-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update slash_in_parameter.rst #4307
Conversation
"name" in requirements is confusing, I had problem for doing the same and then after 2 days I found that the "name" should be same as the parameter, it is not part of symfony config requirements: name: .+
@SamanShafigh Thank you for improving the documentation. However, I'm mixed on this. What do others think? Is the name @weaverryan Should then be merged into 2.3. |
@SamanShafigh what exactly did you find confusing about "name" and how does "username" solve that? (I don't really follow you, so I would like to know more to see if we can fix it) |
Hi, Thanks for the response, The problem for the 'name' is that one might think that the "name" in this cms_show_page: and then after many searches I found that it should be cms_show_page: On Thu, Oct 9, 2014 at 9:15 PM, Wouter J [email protected] wrote:
|
I'm not sure if many people struggle with this. But I can see that you might misunderstand that |
Ah, so you thought However, can you please change this PR to use |
Hi, Thanks for the update, Sure I will change it to username Best Saman On Fri, Oct 10, 2014 at 7:39 PM, Wouter J [email protected] wrote:
|
Thanks for starting this, @SamanShafigh. I've made the final changes and created a new PR: #4400 |
This PR was merged into the 2.3 branch. Discussion ---------- Continues #4307 Continues #4307 | Q | A | --- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - Original PR description: > "name" in requirements is confusing, I had problem for doing the same and then after 2 days I found that the "name" should be same as the parameter, it is not part of symfony config Commits ------- b412780 Changed userName to username 48f453d Update slash_in_parameter.rst
"name" in requirements is confusing, I had problem for doing the same and then after 2 days I found that the "name" should be same as the parameter, it is not part of symfony config
requirements:
name: .+