Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update mvdan.cc/sh to commit 8b67386 #2287

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

dtrudg
Copy link
Member

@dtrudg dtrudg commented Oct 26, 2023

Description of the Pull Request (PR):

Update mvdan.cc/sh to commit 8b67386. This allows execution of action scripts to correctly support parentheses in test / [ commands.

Required to support NVIDIA's NGC container .singularity.d scripts without error.

This fixes or addresses the following GitHub issues:

Before submitting a PR, make sure you have done the following:

@dtrudg dtrudg added bug Something isn't working backport Backport this to stable version labels Oct 26, 2023
@dtrudg dtrudg self-assigned this Oct 26, 2023
Update mvdan.cc/sh to commit 8b67386. This allows execution of action
scripts to correctly support parentheses in `test` / `[` commands.

Required to support NVIDIA's NGC container `.singularity.d` scripts
without error.

Fixes sylabs#2286
@dtrudg dtrudg marked this pull request as ready for review October 26, 2023 15:28
@dtrudg dtrudg requested a review from preminger October 26, 2023 15:28
@dtrudg dtrudg merged commit eb45264 into sylabs:main Oct 26, 2023
1 check passed
@dtrudg dtrudg deleted the mvdan-sh-8b67386 branch October 26, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backport this to stable version bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parentheses not honored for test / [ in container startup scripts
2 participants