Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parentheses not honored for test / [ in container startup scripts #2286

Closed
dtrudg opened this issue Oct 26, 2023 · 0 comments · Fixed by #2287
Closed

Parentheses not honored for test / [ in container startup scripts #2286

dtrudg opened this issue Oct 26, 2023 · 0 comments · Fixed by #2287
Assignees
@dtrudg
Labels
bug Something isn't working
Milestone
SingularityCE 4.0.2

Comments

@dtrudg
Copy link
Member

dtrudg commented Oct 26, 2023

Version of Singularity

main / release-4.0

Describe the bug

See: mvdan/sh#1036
@dtrudg dtrudg added the bug Something isn't working label Oct 26, 2023
@dtrudg dtrudg added this to the SingularityCE 4.0.2 milestone Oct 26, 2023
@dtrudg dtrudg self-assigned this Oct 26, 2023
dtrudg added a commit to dtrudg/singularity that referenced this issue Oct 26, 2023
@dtrudg
deps: update mvdan.cc/sh to commit 8b67386
65c125d 
Update mvdan.cc/sh to commit 8b67386. This allows execution of action
scripts to correctly support parentheses in `test` / `[` commands.

Required to support NVIDIA's NGC container `.singularity.d` scripts
without error.

Fixes sylabs#2286
@dtrudg dtrudg mentioned this issue Oct 26, 2023
Merged
dtrudg added a commit to dtrudg/singularity that referenced this issue Oct 26, 2023
@dtrudg
deps: update mvdan.cc/sh to commit 8b67386 (release-4.0)
015c884 
Update mvdan.cc/sh to commit 8b67386. This allows execution of action
scripts to correctly support parentheses in `test` / `[` commands.

Required to support NVIDIA's NGC container `.singularity.d` scripts
without error.

Fixes sylabs#2286
@dtrudg dtrudg mentioned this issue Oct 26, 2023
Merged
dtrudg added a commit to dtrudg/singularity that referenced this issue Oct 26, 2023
@dtrudg
deps: update mvdan.cc/sh to commit 8b67386 (release-4.0)
2e39153 
Update mvdan.cc/sh to commit 8b67386. This allows execution of action
scripts to correctly support parentheses in `test` / `[` commands.

Required to support NVIDIA's NGC container `.singularity.d` scripts
without error.

Fixes sylabs#2286
dtrudg added a commit to dtrudg/singularity that referenced this issue Oct 26, 2023
@dtrudg
deps: update mvdan.cc/sh to commit 8b67386
27c7d1a 
Update mvdan.cc/sh to commit 8b67386. This allows execution of action
scripts to correctly support parentheses in `test` / `[` commands.

Required to support NVIDIA's NGC container `.singularity.d` scripts
without error.

Fixes sylabs#2286
dtrudg added a commit to dtrudg/singularity that referenced this issue Oct 26, 2023
@dtrudg
deps: update mvdan.cc/sh to commit 8b67386 (release-4.0)
86efb9e 
Update mvdan.cc/sh to commit 8b67386. This allows execution of action
scripts to correctly support parentheses in `test` / `[` commands.

Required to support NVIDIA's NGC container `.singularity.d` scripts
without error.

Fixes sylabs#2286
dtrudg added a commit to dtrudg/singularity that referenced this issue Nov 13, 2023
@dtrudg
deps: update mvdan.cc/sh to commit 8b67386
b8ce299 
Update mvdan.cc/sh to commit 8b67386. This allows execution of action
scripts to correctly support parentheses in `test` / `[` commands.

Required to support NVIDIA's NGC container `.singularity.d` scripts
without error.

Fixes sylabs#2286
@DrDaveD DrDaveD mentioned this issue Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtrudg dtrudg

Labels
bug Something isn't working
Projects
None yet
Milestone
SingularityCE 4.0.2
Development

Successfully merging a pull request may close this issue.

deps: update mvdan.cc/sh to commit 8b67386 dtrudg/singularity
1 participant
@dtrudg