AOP特性微调 #95
Merged
AOP特性微调 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JiankangMai
commented
Mar 29, 2018
JiankangMai
commented
- 既然已经要求环境PHP7.0+，没必要只catch expetion，直接catch throwable
- 原机制是存在切面即屏蔽异常，不太合理。改为没有@AfterThrowing的切面原异常向上层切面继续抛出，存在@AfterThrowing的切面由@AfterThrowing决定是否向上抛出异常 (该点前向不兼容)
- @AfterThrowing 需要有获取异常信息的能力，故在JoinPoint添加Throwable成员；作为快捷方式,在异常通知中可以通过声明通知参数类型直接获取特定类型异常。
|
建议格式化下代码 |
|
@JiankangMai 这个方式可行的，代码格式很多地方没有满足PSR标准，调整下。 |
|
php-cs-fixer用\ROOT\swoft.php_cs 跑过了，除了加上文件版权头没有其他变化，根目录的配置是不是旧的@inhere |
|
额 那个没调整好 我都没有用，自己都习惯psr 2 格式了 |
|
cs-fixer 规则已经应用 PSR2 规则了 |
huangzhhui
pushed a commit
that referenced
this pull request
Jun 12, 2018
* use swoft/swoole-ide-helper * add coWrite() * update * fix logWriter
swoft-bot
pushed a commit
that referenced
this pull request
Nov 21, 2018
* use swoft/swoole-ide-helper * add coWrite() * update * fix logWriter
stelin
pushed a commit
that referenced
this pull request
May 14, 2019
* use swoft/swoole-ide-helper * add coWrite() * update * fix logWriter
stelin
pushed a commit
that referenced
this pull request
May 14, 2019
stelin
pushed a commit
that referenced
this pull request
May 14, 2019
f9910dc Merge commit 'b4f8d0a17a1c9a99274d0e250f6179d14a8728a8' 036d98b Merge branch 'master' of github.com:swoft-cloud/swoft-component 0d9ccbe Update Aop.php (#222) cacd775 修复Number验证器最大和最小的template没有生效的问题 (#218) 7ebaf5f 修复Number验证器最大和最小的template没有生效的问题 (#218) ed18988 fix error on trigger event handler (swoft-cloud/swoft-component#196) bf188ad fix a bug when warnings appear in the high version of swoole (swoft-cloud/swoft-component#195) 4ec3be6 自定义组件支持别名配置 (swoft-cloud/swoft-component#181) 609dd83 修复restart不能正常使用的BUG (swoft-cloud/swoft-component#180) 0bcd9bc 修改连接池配置的timeout字段为float (swoft-cloud/swoft-component#177) 0044361 修改自定义组件只能扫描Aop、Command、Bootstrap三个文件的BUG (swoft-cloud/swoft-component#169) 99916fc 兼容swoole 4.0.3版本 (swoft-cloud/swoft-component#166) a1d6ace 增加用户自定义组件配置 (swoft-cloud/swoft-component#150) d0f7f88 Upstream travis ci config (swoft-cloud/swoft-component#160) afb115f 修复Json Validator会失效的BUG (swoft-cloud/swoft-component#153) 5fdf6c7 修复自定义注解无法使用Aop切面编程的BUG (swoft-cloud/swoft-component#139) 3c147d1 Optimize (swoft-cloud/swoft-component#143) c98825b 修复执行php bin/swoft stop命令时master进程异常未退出的问题，以及停止失败后，pid文件被删除的问题 (#134) 940f76f 修改`ComposerHelper::getDirByNamespace`匹配有误的BUG (swoft-cloud/swoft-component#137) 427dcb6 Update PoolHelper.php (swoft-cloud/swoft-component#131) fc38546 Scan bean according to Composer settings (#115) 851f3f0 Add psysh for debug (swoft-cloud/swoft-component#109) e55fae5 Parse namespace to dir path according to composer settings (swoft-cloud/swoft-component#103) 290a2f4 fix swoft-cloud/swoft#277 (#96) 0d2dade fix logWriter (#95) 1f1af6c Uniform log path format (swoft-cloud/swoft-component#94) 148daeb [fixed]eval error with void method (#92) a22481a [fixed] logger->messages init error (#91) 69975cd add coWrite(); use swoft/swoole-ide-helper (#83) 7f66cef change fix 410b028 fix index err git-subtree-dir: src/framework git-subtree-split: f9910dc
stelin
pushed a commit
that referenced
this pull request
May 28, 2019
* use swoft/swoole-ide-helper * add coWrite() * update * fix logWriter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.