[fixed]eval error with void method (#92)

Fixed bug proxy class generation that when method of target class specify void return type
swoft-cloud · Jun 8, 2018 · 148daeb · 148daeb
1 parent a22481a
commit 148daeb
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/src/Proxy/Proxy.php b/src/Proxy/Proxy.php
@@ -64,7 +64,13 @@ private static function getMethodsTemplate(array $reflectionMethods, string $han
             if ($reflectionMethod->isConstructor() || $reflectionMethod->isStatic()) {
                 continue;
             }
-
+
+            // define override methodBody
+            $methodBody = "{
+                return \$this->{$handlerPropertyName}->invoke('{$methodName}', func_get_args());
+            }
+            ";
+
             // the template of parameter
             $template .= " public function $methodName (";
             $template .= self::getParameterTemplate($reflectionMethod);
@@ -76,13 +82,14 @@ private static function getMethodsTemplate(array $reflectionMethods, string $han
                 $returnType = $reflectionMethodReturn->__toString();
                 $returnType = $returnType === 'self' ? $reflectionMethod->getDeclaringClass()->getName() : $returnType;
                 $template .= " : $returnType";
+                // if returnType is void
+                if ($returnType === 'void') {
+                    $methodBody = str_replace('return ', '', $methodBody);
+                }
             }
 
-            // override method
-            $template .= "{
-                return \$this->{$handlerPropertyName}->invoke('{$methodName}', func_get_args());
-            }
-            ";
+            // append methodBody
+            $template .= $methodBody;
         }
 
         return $template;