[6.1] SILVerifier: fix a wrong check for witness_method instructions #78007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eeckstein
commented
Dec 6, 2024
•
eeckstein
commented
- Explanation: Fixes a verification error caused by a wrong check in the verifier for calling a method of an existential with an opaque return type.
- Scope: Can affect code which uses existentials with opaque return type methods.
- Risk: Very low. It relaxes a verifier condition
- Testing: Tested by a test case.
- Issue: SIL verification failed: Should not have an operand for the opened existential: AMI->getTypeDependentOperands().empty() #77955, rdar://140939536
- Reviewer: @jckarter
- Main branch PR: SILVerifier: fix a wrong check for witness_method instructions #77972
Consider that the lookup-type can be an opaque return type. Also fixing the SILPrinter. Fixes a verifier crash #77955 140939536
|
@swift-ci test |
tbkka
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.