SILVerifier: fix a wrong check for witness_method instructions #77972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider that the lookup-type can be an opaque return type. Also fixing the SILPrinter. Fixes a verifier crash swiftlang#77955 140939536
|
@swift-ci smoke test |
slavapestov
reviewed
Dec 5, 2024
| WMI->getMember().getDecl()->getInterfaceType().print( | ||
| PrintState.OS, QualifiedSILTypeOptions); | ||
| if (!WMI->getTypeDependentOperands().empty()) { | ||
| if ((getLocalArchetypeOf(lookupType) || lookupType->hasDynamicSelfType()) && !WMI->getTypeDependentOperands().empty()) { |
There was a problem hiding this comment.
The commit message talks about opaque archetypes, what's the connection?
There was a problem hiding this comment.
The SILPrinter prints the first type dependent operand as explicit operand. I don't know why.
So far it was the assumption that if the lookupType is an opened archetype then there is exactly 1 type dependent operand. But this is not true for opaque return types, because those have opened archetypes in the substitution list. This SILPrinter change "restores" the original behavior that the explicit operand is printed if the lookupType is an opened archetype.
jckarter
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider that the lookup-type can be an opaque return type.
Also fixing the SILPrinter.
Fixes a verifier crash
#77955
rdar://140939536