Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick changes from IndexStoreDB's copy of LMDB #8

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

matthewbastien
Copy link
Member

IndexStoreDB enables thread sanitization in its builds and made several changes to its copy of LMDB in order to build:

  1. Change uses of volatile to _Atomic
  2. Enable POSIX mutexes on non-Windows platforms
  3. Disable robust mutexes since they only apply to multi-process access of databases

IndexStoreDB also sets MDB_MAXKEYSIZE to 0 in order to tell LMDB to use the max computed key size.

Copy link

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks! I'm glad swift-lmdb is getting picked up by more projects; it's otherwise a forgotten component of Swift-DocC. 😅

@QuietMisdreavus QuietMisdreavus merged commit 8a4cce1 into swiftlang:main Dec 16, 2024
@matthewbastien matthewbastien deleted the indexstoredb-changes branch December 16, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants