Use swift-lmdb instead of copying LMDB source #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbastien
force-pushed
the
swift-lmdb
branch
from
6656347 to
8464623
Compare
ahoppen
reviewed
Nov 14, 2024
|
@swift-ci please test |
|
Please test with following PRs: @swift-ci please test |
|
@swift-ci please test |
|
Please test with following PRs: @swift-ci please test Windows platform |
|
Please test with the following PRs: @swift-ci please test Windows platform |
bnbarham
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is tracked by rdar://139431575 as a part of swiftlang/vscode-swift#562
Adds swift-lmdb as a dependency and removes the copied lmdb source so that IndexStoreDB uses the same version of lmdb as swift-docc. This enables SourceKit-LSP to use swift-docc as a dependency to fulfill documentation requests on behalf of the VS Code Swift extension.