Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.1] Remove beta tag from unavailable symbols. (#1121) #1122

Conversation

sofiaromorales
Copy link
Contributor

  • Explanation: Symbols that are unconditionally unavailable in all the platforms should not be tagged as beta. Before this fix the isBeta logic was returning true for symbols that were unavailable in all the platforms. Now is filtering out these platforms before assessing if it's beta or not.
  • Scope: Symbol availability information.
  • Issue: rdar://140415995
  • Risk: Low
  • Testing: New tests added to verify that a symbol is not marked in beta if all the platforms are unavailable.
  • Reviewer: @d-ronnqvist
  • Original PR: Remove beta tag from unavailable symbols. #1121

Symbols that are unconditionally unavailable in all the platforms should not be
tagged as beta. Before this fix the `isBeta` logic was returning true for symbols
that were unavailable in all the platforms. Now is filtering out these platforms
before assesing if it's beta or not.

rdar://140415995
@sofiaromorales
Copy link
Contributor Author

@swift-ci please test

@sofiaromorales sofiaromorales merged commit f85f514 into swiftlang:release/6.1 Dec 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants