Remove beta tag from unavailable symbols. #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symbols that are unconditionally unavailable in all the platforms should not be tagged as beta.Before this fix the `isBeta` logic was returning true for symbols that were unavailable in all the platforms. Now is filtering out these platforms before assesing if it's beta or not. rdar://140415995
sofiaromorales
requested review from
d-ronnqvist and
anferbui
and removed request for
d-ronnqvist
|
@swift-ci please test |
sofiaromorales
added a commit
to sofiaromorales/swift-docc
that referenced
this pull request
Dec 9, 2024
Symbols that are unconditionally unavailable in all the platforms should not be tagged as beta. Before this fix the `isBeta` logic was returning true for symbols that were unavailable in all the platforms. Now is filtering out these platforms before assesing if it's beta or not. rdar://140415995
sofiaromorales
added a commit
that referenced
this pull request
Dec 9, 2024
Symbols that are unconditionally unavailable in all the platforms should not be tagged as beta. Before this fix the `isBeta` logic was returning true for symbols that were unavailable in all the platforms. Now is filtering out these platforms before assesing if it's beta or not. rdar://140415995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable: 140415995
Summary
Symbols that are unconditionally unavailable in all the platforms should not be tagged as beta.Before this fix the
isBetalogic was returning true for symbols that were unavailable in all the platforms. Now is filtering out these platforms before assesing if it's beta or not.Dependencies
Describe any dependencies this PR might have, such as an associated branch in another repository.
Testing
See unit tests.
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded