Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Swift Package Manager. #77

Merged
merged 5 commits into from
Jun 14, 2019

Conversation

orangeince
Copy link
Contributor

I find this repo when I try to make a small tool to parse csv files. It's awesome! But the only regret is that it does not support SPM. So I made this PR to do something for others.

It is easy to use new version of swift tool. But there is one not good of SPM, it does not support include resources with targets, it's a bug. So, in order to pass the test case, I added a ResourceHelper to get the url of resource.

@codecov-io
Copy link

codecov-io commented May 9, 2019

Codecov Report

Merging #77 into master will decrease coverage by 0.56%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   92.53%   91.96%   -0.57%     
==========================================
  Files          13       14       +1     
  Lines         415      423       +8     
==========================================
+ Hits          384      389       +5     
- Misses         31       34       +3
Impacted Files Coverage Δ
SwiftCSVTests/URLTests.swift 100% <100%> (ø) ⬆️
SwiftCSVTests/PerformanceTest.swift 100% <100%> (ø) ⬆️
SwiftCSVTests/ResourceHelper.swift 62.5% <62.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a5ac63...9bcefaa. Read the comment docs.

Copy link
Contributor

@DivineDominion DivineDominion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! The ResourceHelper is a reasonable addition. Didn't know about SPM's limitation on this.

@DivineDominion DivineDominion merged commit f918bde into swiftcsv:master Jun 14, 2019
@DivineDominion
Copy link
Contributor

DivineDominion commented Jun 14, 2019

Thanks for contributing! I've invited you to join the SwiftCSV GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines.

@orangeince
Copy link
Contributor Author

@DivineDominion Cool! I'd like to do something to make it prefect!

lukestringer90 pushed a commit to lukestringer90/SwiftCSV that referenced this pull request Apr 4, 2020
* add SwiftPackageManager support.
* add resourcehelper's file reference to fix test error in SwiftPM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants