Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Swift Package Manager #52

Closed
kgn opened this issue Jan 26, 2017 · 6 comments
Closed

Add support for Swift Package Manager #52

kgn opened this issue Jan 26, 2017 · 6 comments

Comments

@kgn
Copy link

kgn commented Jan 26, 2017

I'd like to use this with Vapor which uses Swift Package Manger for dependencies.

@grantkemp
Copy link
Collaborator

Hi - its a good idea, but I am not that familiar with with SPM - can you submit a pull request? and we can plan for the release after next?

@kgn
Copy link
Author

kgn commented Feb 6, 2017

I wasn't familiar with the steps involved with making a package, but after some reading it seems the only thing that's needed is a Package.swift file and to put all the source files in a Sources directory and move SwiftCSVTests into a Tests directory. However, when I attempted to do this in a fork I ran into compile issues as the code needs to be updated for Swift 3 and there were some things that didn't automatically convert.

Do you plan on updating the library to Swift 3?

Package.swift

import PackageDescription

let package = Package(
    name: "SwiftCSV"
)

@wpuricz
Copy link

wpuricz commented Feb 8, 2017

I would also like to see this as a swift package so that I can use it in Vapor and for command line applications.

@grantkemp
Copy link
Collaborator

@kgn we now have a swift 3 version the develop branch. Do you want to try it out and potentially submit SPM fix against that ? and we can release at same time

@kgn
Copy link
Author

kgn commented Jun 9, 2017

Finally got around to this: #58

@DivineDominion
Copy link
Contributor

Done in #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants