-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update available OSes to match available runner images #675
Conversation
macos-10, ubuntu-18.04 and ubuntu-16.04 are no longer available and have been removed. macos-11 now corresponds to OS version 11.7 and macos-12 now corresponds to OS version 12.7, so the minor versions have been removed from the macOS list. Finally, this commit adds 24.04 to the Ubuntu platform list, as it is now available in beta. See https://github.com/actions/runner-images?tab=readme-ov-file#available-images
These lines should be unnecessary if the intent was to test the latest versions of MacOS and Ubuntu; they are already in the matrix via lines above.
0d820eb
to
5040710
Compare
f4f0cc1
to
4af1f36
Compare
Thank you so much for your contribution @angelapwen! 🙌🏻 |
Thank you @fwal for the review! Quick question: it seems the "release drafter" automation to pack the dist has not run yet on this PR or on |
Yeah somehow the release drafter workflow is having permission issues, looking into it 👀 |
Hmmmm darn I just tested a run on
On the other runner images it works fine though 🤔 |
Currently available runner images are listed at https://github.com/actions/runner-images?tab=readme-ov-file#available-images.
The change is along the lines of #473 when ubuntu-22.04 was added so 🤞 this works.
Fixes #674.
I also made an update to the integration test matrix, see comments separately.