Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update available OSes to match available runner images #675

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

angelapwen
Copy link
Contributor

@angelapwen angelapwen commented Jun 28, 2024

Currently available runner images are listed at https://github.com/actions/runner-images?tab=readme-ov-file#available-images.

  • macos-10, ubuntu-18.04 and ubuntu-16.04 are no longer available and have been removed.
  • macos-11 now corresponds to OS version 11.7 and macos-12 now corresponds to OS version 12.7, so the minor versions have been removed from the macOS list.
  • ubuntu-24.04 is now available in beta so it has been added to the Ubuntu platform list.

The change is along the lines of #473 when ubuntu-22.04 was added so 🤞 this works.

Fixes #674.

I also made an update to the integration test matrix, see comments separately.

macos-10, ubuntu-18.04 and ubuntu-16.04 are no longer available and have been removed.

macos-11 now corresponds to OS version 11.7 and macos-12 now corresponds to OS version 12.7, so the minor versions have been removed from the macOS list.

Finally, this commit adds 24.04 to the Ubuntu platform list, as it is now available in beta.

See https://github.com/actions/runner-images?tab=readme-ov-file#available-images
These lines should be unnecessary if the intent was to test the latest versions of MacOS and Ubuntu; they are already in the matrix via lines above.
@angelapwen angelapwen marked this pull request as ready for review June 28, 2024 16:22
@angelapwen angelapwen force-pushed the update-available-images branch from 0d820eb to 5040710 Compare July 1, 2024 11:37
@angelapwen angelapwen force-pushed the update-available-images branch from f4f0cc1 to 4af1f36 Compare July 1, 2024 11:50
@fwal fwal self-assigned this Jul 3, 2024
@fwal fwal added the enhancement New feature or request label Jul 3, 2024
@fwal
Copy link
Collaborator

fwal commented Jul 3, 2024

Thank you so much for your contribution @angelapwen! 🙌🏻

@fwal fwal merged commit 2fc45c4 into swift-actions:main Jul 3, 2024
8 checks passed
@angelapwen
Copy link
Contributor Author

Thank you @fwal for the review!

Quick question: it seems the "release drafter" automation to pack the dist has not run yet on this PR or on main: should it have?

@fwal
Copy link
Collaborator

fwal commented Jul 3, 2024

Yeah somehow the release drafter workflow is having permission issues, looking into it 👀

@angelapwen
Copy link
Contributor Author

Hmmmm darn I just tested a run on ubuntu-24.04 and I'm getting this error:

Error: Unexpected error, unable to continue. Please report at https://github.com/swift-actions/setup-swift/issues
Unexpected HTTP response: 404
Stacktrace:
Error: Unexpected HTTP response: 404
    at /home/runner/work/_actions/swift-actions/setup-swift/3aed395c5397f62deb91d8fe7af1418a9ae4d16f/dist/index.js:4827:25
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/_actions/swift-actions/setup-swift/3aed395c5397f62deb91d8fe7af1418a9ae4d16f/dist/index.js:4737:58)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

On the other runner images it works fine though 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ubuntu-24.04 OS version
2 participants