-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation done:Lesson 8 #35
Conversation
I've resolved the "conflicts" mentioned. To add further changes, either "review" PR #36 or pull the changes there and push to this repo.
|
Thank you for resolving the conflict! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that took so long! Better late than never, I hope. Please see my comments and suggested changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
うまく翻訳できてます。
あとはレビューコメントの変更点を加えれば、マージできると思います。
Changes requested have been reflected in a separate PR to DaichiSaitoAF's repo
I have requested a PR to @DaichiSaitoAF 's repo that reflects all of the changes from the reviews. If you could merge the this PR, the changes should automatically appear here, and then I can merge it in |
Not entirely sure how but I managed to push changes to this PR before. Note that #36 was closed not merged. Let’s give Dai a chance to see it but if he’s not available to respond it should be possible to update the PR by pushing the right branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this just merges changes from the organisation branch into Dai's PR (can be merged without conflicts now)
I attempted to translate Lesson 8.