Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Japanese License to all SWC lessons #131

Merged
merged 9 commits into from
Nov 23, 2020

Conversation

TomKellyGenetics
Copy link
Member

@TomKellyGenetics TomKellyGenetics commented Oct 17, 2020

Migrates the License translated in PR #127 for R novice gapminder to all lessons. Also translates the title on the License webpage.

  • Git novice

  • Make novice

  • Shell novice

  • SQL novice survey

  • Python novice gapminder

  • Python novice inflammation

  • R novice inflammation

This should be a quick one as all Japanese text has been reviewed already.

@TomKellyGenetics
Copy link
Member Author

@rikutakei are you able to check this one? Seem like the Git License was already translated but I think consistency with the R lessons is better: #127

@TomKellyGenetics
Copy link
Member Author

Note that David has proposed to automate this:
#11
carpentries-i18n#9

Let's merge for now anyway, we can always migrate to automating it. I'm also okay to apply changes across all lessons with sed as they come up. It would be rare for these sections to be changed anyway.

@TomKellyGenetics TomKellyGenetics linked an issue Nov 23, 2020 that may be closed by this pull request
@joelnitta joelnitta merged commit 5580836 into swcarpentry-ja:ja Nov 23, 2020
@TomKellyGenetics TomKellyGenetics mentioned this pull request Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate changes to other lessons
2 participants