-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translated title of content #114
Conversation
Regarding this conflict.
Conflict appears to have been merged here: Previous commit doesn't have this so it seems to have merged from another branch. Related PR: #50 @atusy seems to have translated this part while doing R lesson 11 - writing data (his copy is the 1st one -- I'll leave it here to consider it in review). I'm going to merge conflicts with @masamiy's version for consistency with other lessons. We have discussed some of these terms before here. |
…h 'master' and resolve conflicts
As mentioned before, I think we don't need to change repeated words @masamiy I've done this for you: masamiy#1 This also updates |
See the preview for @atusy's translations. https://swcarpentry-ja.github.io/r-novice-gapminder/ja/_episodes/10-functions/index.html If you change this template terms in English, the lesson won't display correctly. This commit should correct this: masamiy@9cd9432 |
Correct conflicts for Masami
Co-authored-by: Tom Kelly <[email protected]>
Add changes to lang.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
You don't need to add 分 after the minutes (e.g., 45 not 45分), since it will get added automatically when the website is rendered. @TomKellyGenetics will take those out from this PR though, so don't worry about it.
I noticed you often included a space after Roma-ji (for example, "R は" vs. "Rは"). I think we need to decide as a group what the appropriate style should be, so I didn't suggest to remove them in most cases.
Co-authored-by: Joel Nitta <[email protected]>
Co-authored-by: Joel Nitta <[email protected]>
Co-authored-by: Joel Nitta <[email protected]>
Co-authored-by: Joel Nitta <[email protected]>
Co-authored-by: Joel Nitta <[email protected]>
Co-authored-by: Tom Kelly <[email protected]>
Co-authored-by: Joel Nitta <[email protected]>
Co-authored-by: Joel Nitta <[email protected]>
Co-authored-by: Joel Nitta <[email protected]>
Co-authored-by: Joel Nitta <[email protected]>
Turns out you can commit multiple suggestions in batches. Handy! :)
This removes 分 for minutes as discussed above (and undoes some mistakes I made in the process of doing that). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is almost done! 👍
I think we've reviewed this thoroughly enough. Great job team! |
forgot to mention... this resolves issue #111 |
PR #115 seems to have been merged at the same time 👍 |
Lessons updated: https://swcarpentry-ja.github.io/r-novice-gapminder/ja/index/ @joelnitta or @rikutakei should be able to do this by running this in future.
|
There are conflicts and Joel and Masami hope Tom can fix them!!