Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated title of content #114

Merged
merged 24 commits into from
Sep 9, 2020
Merged

Translated title of content #114

merged 24 commits into from
Sep 9, 2020

Conversation

masamiy
Copy link
Collaborator

@masamiy masamiy commented Aug 28, 2020

There are conflicts and Joel and Masami hope Tom can fix them!!

@TomKellyGenetics
Copy link
Member

TomKellyGenetics commented Aug 29, 2020

Regarding this conflict.

+15490 po/r-novice-gapminder.ja.po
<<<<<<< HEAD
"title: データの出力\n"
"講義: 10\n"
"練習: 10\n"
"質問:\n"
"- \"Rで作った図を保存するにはどうしますか?\"\n"
"目標:\n"
"- \"R から図やデータを 出力出来るようになりましょう。\"\n"
"要点:\n"
"- \"RStudio のエクスポートボタンを使って図を保存しましょう。\"\n"
"- \"`write.table` を使って表形式のデータを保存しましょう。\"\n"
=======
"title: データの書き込み\n"
"講義: 10 分\n"
"演習: 10 分\n"
"質問:\n"
"- \"R で作成したプロットやデータを保存するにはどうすればよいですか?\"\n"
"目標:\n"
"- \"R からプロットやデータを書き出せるようになりましょう。\"\n"
"キーポイント:\n"
"- \"'Export' ボタンを使って RStudio からプロットの保存が出来る。\"\n"
"- \"`write.table` を使って表形式のデータの保存が出来る。\"\n"
>>>>>>> cc00d4d8e985e1fc2c0d6303037f8a982a98e70a

Conflict appears to have been merged here:

Screen Shot 2020-08-29 at 17 41 40

Previous commit doesn't have this so it seems to have merged from another branch.

Screen Shot 2020-08-29 at 17 45 36

Related PR: #50

@atusy seems to have translated this part while doing R lesson 11 - writing data (his copy is the 1st one -- I'll leave it here to consider it in review). I'm going to merge conflicts with @masamiy's version for consistency with other lessons. We have discussed some of these terms before here.

@TomKellyGenetics
Copy link
Member

@masamiy if you "merge" this pull request, it will resolved conflicts in your branch: masamiy#1

@TomKellyGenetics
Copy link
Member

TomKellyGenetics commented Aug 29, 2020

As mentioned before, I think we don't need to change repeated words teaching:, exercises:, objectives: in the lesson template. Doing this once in lang.md allows po4gitbook to do this automatically. Please change this file instead.

@masamiy I've done this for you: masamiy#1
masamiy@9cd9432

This also updates lang.md to be consistent with Masami's translations. We can discuss this changes in this PR once they're merged into Masami's branch, they should appear here. https://github.com/swcarpentry-ja/i18n/pull/114/files

@TomKellyGenetics
Copy link
Member

See the preview for @atusy's translations.

https://swcarpentry-ja.github.io/r-novice-gapminder/ja/_episodes/10-functions/index.html
https://swcarpentry-ja.github.io/r-novice-gapminder/ja/_episodes/11-writing-data/index.html

If you change this template terms in English, the lesson won't display correctly. This commit should correct this: masamiy@9cd9432

@joelnitta joelnitta self-assigned this Sep 1, 2020
This was referenced Sep 2, 2020
lang.md Outdated Show resolved Hide resolved
Copy link
Member

@joelnitta joelnitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
You don't need to add 分 after the minutes (e.g., 45 not 45分), since it will get added automatically when the website is rendered. @TomKellyGenetics will take those out from this PR though, so don't worry about it.
I noticed you often included a space after Roma-ji (for example, "R は" vs. "Rは"). I think we need to decide as a group what the appropriate style should be, so I didn't suggest to remove them in most cases.

po/r-novice-gapminder.ja.po Outdated Show resolved Hide resolved
po/r-novice-gapminder.ja.po Outdated Show resolved Hide resolved
po/r-novice-gapminder.ja.po Outdated Show resolved Hide resolved
po/r-novice-gapminder.ja.po Outdated Show resolved Hide resolved
po/r-novice-gapminder.ja.po Outdated Show resolved Hide resolved
po/r-novice-gapminder.ja.po Outdated Show resolved Hide resolved
po/r-novice-gapminder.ja.po Outdated Show resolved Hide resolved
po/r-novice-gapminder.ja.po Outdated Show resolved Hide resolved
po/r-novice-gapminder.ja.po Outdated Show resolved Hide resolved
po/r-novice-gapminder.ja.po Outdated Show resolved Hide resolved
Turns out you can commit multiple suggestions in batches. Handy! :)
@TomKellyGenetics
Copy link
Member

This removes 分 for minutes as discussed above (and undoes some mistakes I made in the process of doing that).

Copy link
Member

@TomKellyGenetics TomKellyGenetics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is almost done! 👍

@joelnitta
Copy link
Member

I think we've reviewed this thoroughly enough. Great job team!

@joelnitta joelnitta merged commit 71daf97 into swcarpentry-ja:ja Sep 9, 2020
@joelnitta
Copy link
Member

forgot to mention... this resolves issue #111

@TomKellyGenetics
Copy link
Member

PR #115 seems to have been merged at the same time 👍

@TomKellyGenetics
Copy link
Member

Lessons updated: https://swcarpentry-ja.github.io/r-novice-gapminder/ja/index/

@joelnitta or @rikutakei should be able to do this by running this in future.

sh wrapper.sh --repo r-novice-gapminder --account swcarpentry-ja --webpages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical For improvements to scripts and issues with webpages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with R-novice-gapminder table of contents and headers
4 participants