Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es/parser): Disallow let let #9484

Merged
merged 7 commits into from
Aug 22, 2024
Merged

feat(es/parser): Disallow let let #9484

merged 7 commits into from
Aug 22, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Aug 22, 2024

@kdy1 kdy1 added this to the Planned milestone Aug 22, 2024
@kdy1 kdy1 self-assigned this Aug 22, 2024
@kdy1 kdy1 requested a review from a team as a code owner August 22, 2024 06:32
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 22, 2024
Copy link

changeset-bot bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: e4cb1e1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 enabled auto-merge (squash) August 22, 2024 06:32
@kdy1 kdy1 requested a review from a team as a code owner August 22, 2024 06:32
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 22, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 22, 2024
Copy link

codspeed-hq bot commented Aug 22, 2024

CodSpeed Performance Report

Merging #9484 will degrade performances by 35.15%

Comparing kdy1:issue-8269 (e4cb1e1) with main (ede1a52)

Summary

❌ 3 regressions
✅ 175 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:issue-8269 Change
es/full/bugs-1 550.1 µs 583.2 µs -5.68%
es/full/base/fixer 116.2 µs 179.1 µs -35.15%
es/full/codegen/es2015 275.2 µs 290.2 µs -5.17%

@kdy1 kdy1 merged commit 1121bc0 into swc-project:main Aug 22, 2024
154 checks passed
@kdy1 kdy1 deleted the issue-8269 branch August 22, 2024 09:17
@kdy1 kdy1 modified the milestones: Planned, v1.7.17 Aug 23, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

passing let let to the parser should throw an error
1 participant