Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/parser): Fix let parsing in scripts to match spec #9343

Closed
wants to merge 3 commits into from

Conversation

zrosenbauer
Copy link
Contributor

@zrosenbauer zrosenbauer commented Jul 29, 2024

Description:

Fix for #8269

WIP - still need to tweak tests & verify running as strict: false

BREAKING CHANGE:

Related issue (if exists):

Copy link

changeset-bot bot commented Jul 29, 2024

⚠️ No Changeset found

Latest commit: 0e27a67

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zrosenbauer zrosenbauer changed the title fix: Fix let parsing in scripts to match spec fix(es/parser): Fix let parsing in scripts to match spec Jul 29, 2024
Copy link

codspeed-hq bot commented Jul 29, 2024

CodSpeed Performance Report

Merging #9343 will degrade performances by 5.6%

Comparing zrosenbauer:fix/let-let-parser (0e27a67) with main (1454ab5)

Summary

⚡ 2 improvements
❌ 4 regressions
✅ 172 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main zrosenbauer:fix/let-let-parser Change
es/full/bugs-1 590.2 µs 530.9 µs +11.17%
es/full/codegen/es2015 291.6 µs 282 µs +3.41%
es/visitor/base-perf/boxing_boxed 3.1 µs 3.2 µs -3.66%
es/visitor/base-perf/boxing_boxed_clone 2.3 µs 2.4 µs -3.72%
es/visitor/base-perf/boxing_unboxed 3.3 µs 3.4 µs -4.29%
es/visitor/base-perf/boxing_unboxed_clone 2.5 µs 2.6 µs -5.6%

@mischnic
Copy link
Contributor

This is fixed now by #9484

@kdy1 kdy1 closed this Aug 23, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants