remove pandoc dependency from main game #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostmo
force-pushed
the
refactor/mv-pandoc-dependency
branch
from
85a0479 to
df300ee
Compare
kostmo
changed the title
kostmo
commented
Jul 29, 2024
byorgey
approved these changes
Jul 29, 2024
|
@kostmo Will this work in release as the file is not specifically mentioned in cabal? If this temporal state persists too long an integration test to keep it up to date could be useful. I am not against merging it, just wary about potential issues if we forget about it. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2083
Rendering a matrix of command attributes was originally implemented in #1658. But this generated the data to drive the table at runtime, which pulled in an unfortunate Pandoc dependency.
To work around this, let's just pre-generate the data offline.
Demo
scripts/play.sh