Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-game.sh should not require pandoc #2083

Closed
kostmo opened this issue Jul 28, 2024 · 2 comments · Fixed by #2084
Closed

build-game.sh should not require pandoc #2083

kostmo opened this issue Jul 28, 2024 · 2 comments · Fixed by #2084
Assignees
@kostmo
Labels
Z-Developer Experience This issue seeks to make life easier for developers writing Scenarios or other Swarm code.

Comments

@kostmo
Copy link
Member

kostmo commented Jul 28, 2024 •
edited
Loading

Currently, swarm-web depends on swarm-doc, which uses pandoc. Since the swarm executable depends on swarm-web, we end up compiling pandoc just to play the game.

We probably should be able to remove the swarm-doc dependency from swarm-web.
@kostmo kostmo added Z-Feature A new feature to be added to the game. Z-Developer Experience This issue seeks to make life easier for developers writing Scenarios or other Swarm code. and removed Z-Feature A new feature to be added to the game. labels Jul 28, 2024
@byorgey
Copy link
Member

byorgey commented Jul 28, 2024 •
edited
Loading

Are you saying that swarm-web only depends on parts of swarm-doc that don't use pandoc? Perhaps the solution is to split swarm-doc?

@kostmo kostmo mentioned this issue Jul 28, 2024
Merged
@kostmo kostmo self-assigned this Jul 29, 2024
@xsebek
Copy link
Member

xsebek commented Jul 29, 2024

@kostmo, thanks for bringing this up. 👍

I just had to recompile Swarm with older GHC and noticed a lot of time was spent compiling Pandoc.

@mergify mergify bot closed this as completed in #2084 Jul 30, 2024
@mergify mergify bot closed this as completed in f3a15c6 Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostmo kostmo

Labels
Z-Developer Experience This issue seeks to make life easier for developers writing Scenarios or other Swarm code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove pandoc dependency from main game swarm-game/swarm
3 participants
@kostmo @byorgey @xsebek