Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: alecthomas/template -> text/template #891

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

akojo
Copy link
Contributor

@akojo akojo commented Mar 1, 2021

Describe the PR

Since alecthomas/template is based on a severely outdated version (1.4)
of Go standard library, replace it with text/template in generated code.

Update example docs to match the change.

Additional context

Current code doesn't seem to be using newline elision anywhere. In case
that would be needed, text/template has supported it since Go 1.6.

Since alecthomas/template is based on a severly outdated version (1.4)
of Go standard library, replace it with text/template in generated
code.

Update example docs to current swag version.
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #891 (2f3b7db) into master (e7c5cda) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #891   +/-   ##
=======================================
  Coverage   84.83%   84.83%           
=======================================
  Files           8        8           
  Lines        1649     1649           
=======================================
  Hits         1399     1399           
  Misses        145      145           
  Partials      105      105           
Impacted Files Coverage Δ
gen/gen.go 95.27% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7c5cda...2f3b7db. Read the comment docs.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan
Copy link
Contributor

ubogdan commented Mar 1, 2021

@easonlin404 any input here?

@easonlin404
Copy link
Member

LGTM I think text/template standard lib is more suitable if we want to get support and more stable.

@ubogdan ubogdan merged commit 19e5237 into swaggo:master Mar 1, 2021
@ubogdan
Copy link
Contributor

ubogdan commented Mar 1, 2021

@akojo Thanks for your contributions.

@olliefr
Copy link

olliefr commented Mar 14, 2021

Closes issue #754, just saying 🙃

@olliefr
Copy link

olliefr commented May 5, 2021

@ubogdan hey, sorry to trouble you but do you guys have any time scale for the next version-tagged release, pretty please? 🙏 I'm very anxious to get rid of the alecthomas/template dependency in our project 😅

@christian-kreuzberger-dtx

Same here!

@shepherdjerred
Copy link

shepherdjerred commented Jan 11, 2022

Thanks for removing this dependency! This made our lives a bit easier :)

@ubogdan
Copy link
Contributor

ubogdan commented Jan 11, 2022

You're wellcome.

@akojo akojo deleted the chore/remove-alecthomas-template branch April 12, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants