-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: alecthomas/template -> text/template #891
Conversation
Since alecthomas/template is based on a severly outdated version (1.4) of Go standard library, replace it with text/template in generated code. Update example docs to current swag version.
Codecov Report
@@ Coverage Diff @@
## master #891 +/- ##
=======================================
Coverage 84.83% 84.83%
=======================================
Files 8 8
Lines 1649 1649
=======================================
Hits 1399 1399
Misses 145 145
Partials 105 105
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@easonlin404 any input here? |
LGTM I think |
@akojo Thanks for your contributions. |
Closes issue #754, just saying 🙃 |
@ubogdan hey, sorry to trouble you but do you guys have any time scale for the next version-tagged release, pretty please? 🙏 I'm very anxious to get rid of the |
Same here! |
Thanks for removing this dependency! This made our lives a bit easier :) |
You're wellcome. |
Describe the PR
Since alecthomas/template is based on a severely outdated version (1.4)
of Go standard library, replace it with text/template in generated code.
Update example docs to match the change.
Additional context
Current code doesn't seem to be using newline elision anywhere. In case
that would be needed,
text/template
has supported it since Go 1.6.