Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std package to work with templates #754

Closed
ShoshinNikita opened this issue Jul 18, 2020 · 1 comment
Closed

Use std package to work with templates #754

ShoshinNikita opened this issue Jul 18, 2020 · 1 comment

Comments

@ShoshinNikita
Copy link
Contributor

Hello. I noticed swag uses github.com/alecthomas/template instead of text/template. Is there any reason to use this third-party dependency? I couldn't find any usage of its main feature:

a backslash immediately after a closing delimiter will delete all subsequent newlines until a non-newline

I think it would be better to use the std package. Especially because code of github.com/alecthomas/template hasn't been updated since 2015

@olliefr
Copy link

olliefr commented Mar 14, 2021

I'd like to +1 this issue. An extra dependency on a fork of an out-of-date version of standard library module, last updated in 2015. Is there really an engineering need for this, please? 🙃

UPDATE: Just found PR #891 had been merged. Thank you! Looking forward to a tagged release without this dependency ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants