Implement basic OpenTelemetry support #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-daniel
force-pushed
the
daniel/opentelemetry
branch
from
c0a5142 to
8a7d27b
Compare
svix-dylan
previously approved these changes
Jun 27, 2022
tasn
reviewed
Jun 27, 2022
|
I haven't really reviewed the code, as Dylan already has, I just reviewed the docs + main.rs. Though it looks great from what I've seen! |
tasn
reviewed
Jun 29, 2022
tasn
reviewed
Jun 29, 2022
added 9 commits
June 29, 2022 11:21
svix-daniel
force-pushed
the
daniel/opentelemetry
branch
from
8a7d27b to
aafbfaa
Compare
tasn
approved these changes
Jun 29, 2022
This was referenced Jun 29, 2022
svix-daniel
added a commit
that referenced
this pull request
Jun 29, 2022
Fixes a README segment with a typo Follow up to #522
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates OpenTelemetry support and creates middleware for Axum that ensures that the spans created for each request follow OpenTelemetry conventions.
Fixes #344