Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using the OpenTelemetry crate for telemtry #344

Closed
tasn opened this issue Mar 27, 2022 · 7 comments · Fixed by #522
Closed

Start using the OpenTelemetry crate for telemtry #344

tasn opened this issue Mar 27, 2022 · 7 comments · Fixed by #522
Assignees
Labels
server Issues regarding the server component

Comments

@tasn tasn added the server Issues regarding the server component label Mar 27, 2022
@cawfeecoder
Copy link

cawfeecoder commented Mar 30, 2022

@tasn I think you'll get better use out of https://github.com/tokio-rs/tracing. It supports OpenTelemetry (amongst a host of other providers as well), which should give an end consumer of Svix (self-hosted) options for monitoring/observability.

I tend to use tracing to generate Jaegar/OpenTelemetry compatible tracing, and rely on something like https://github.com/metrics-rs/metrics for the Prometheus endpoint (I run an OpenTelemetry sidecar in k8s to scrape the pod, but I figure almost anyone interested in metrics is going to be running an OpenTelemetry scraper somewhere external).

EDIT: My bad, I realize the metrics portion of OpenTelemetry seems somewhat stable (well... alpha) now.

@tasn
Copy link
Member Author

tasn commented Mar 30, 2022

Thanks @cawfeecoder! We are using tracing, the idea is to use the opentelemetry tracing plugin. Though thanks for the feedback, we'll check the built-in stuff in tracing too.

@tasn tasn changed the title Start using the OpneTelemtry crate for telemtry Start using the OpenTelemetry crate for telemtry Apr 18, 2022
@svix-daniel svix-daniel self-assigned this May 17, 2022
@alexrejto
Copy link

Hi @tasn,
For our planning purposes, do you have any update on when opentelemetry will land? Thanks for all your help!

@tasn
Copy link
Member Author

tasn commented Jun 9, 2022

Hey @alexrejto, when would you like to have it by?

@alexrejto
Copy link

Any chance you could fit it in in the next month?

@tasn
Copy link
Member Author

tasn commented Jun 13, 2022

Unless there are surprises, I believe we can.

We'll aim to get it ready in the next couple of weeks.

svix-daniel added a commit that referenced this issue Jun 29, 2022
This PR integrates OpenTelemetry support and creates middleware for Axum that
ensures that the spans created for each request follow OpenTelemetry conventions

Fixes #344
@svix-daniel
Copy link
Contributor

This has been fixed in #522.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Issues regarding the server component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants