-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start using the OpenTelemetry crate for telemtry #344
Comments
@tasn I think you'll get better use out of https://github.com/tokio-rs/tracing. It supports OpenTelemetry (amongst a host of other providers as well), which should give an end consumer of Svix (self-hosted) options for monitoring/observability. I tend to use tracing to generate Jaegar/OpenTelemetry compatible tracing, and rely on something like https://github.com/metrics-rs/metrics for the Prometheus endpoint (I run an OpenTelemetry sidecar in k8s to scrape the pod, but I figure almost anyone interested in metrics is going to be running an OpenTelemetry scraper somewhere external). EDIT: My bad, I realize the metrics portion of OpenTelemetry seems somewhat stable (well... alpha) now. |
Thanks @cawfeecoder! We are using tracing, the idea is to use the opentelemetry tracing plugin. Though thanks for the feedback, we'll check the built-in stuff in tracing too. |
Hi @tasn, |
Hey @alexrejto, when would you like to have it by? |
Any chance you could fit it in in the next month? |
Unless there are surprises, I believe we can. We'll aim to get it ready in the next couple of weeks. |
This PR integrates OpenTelemetry support and creates middleware for Axum that ensures that the spans created for each request follow OpenTelemetry conventions Fixes #344
This has been fixed in #522. |
https://github.com/open-telemetry/opentelemetry-rust
Also: don't forget to update the docs/README to explain how to use it with datadog/newrelic/sentry.
More info / related attempts:
Trace
compatible with OpenTelemetry tower-rs/tower-http#180The text was updated successfully, but these errors were encountered: