New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable `golangci-lint`'s default excluded issues #73

Merged

svengreb merged 1 commit into main from improvement/gh-72-disable-golangci-lint-default-excluded-issues

Nov 21, 2021

Owner

svengreb commented Nov 21, 2021

Resolves #72


          Disable golangci-lint's default excluded issues

3bf0998

By default golangci-lint [2] excludes specific issues (matches) that are
known to be "annoying", but this also included issues explicitly enabled
by this template, e.g. the revive [3] rule to check that exported
function and methods always have a comment [4].
To prevent these issues to be found the default excludes have been
disabled through the `issues.exclude-use-default` configuration field.

[1]: https://golangci-lint.run/usage/configuration/#config-file
[2]: https://golangci-lint.run
[3]: https://github.com/mgechev/revive
[4]: https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#exported

GH-72

svengreb added type-improvement context-techstack scope-quality labels

svengreb added this to the Next milestone

svengreb self-assigned this

svengreb merged commit c099c6e into main

svengreb deleted the improvement/gh-72-disable-golangci-lint-default-excluded-issues branch

November 21, 2021 11:15

svengreb removed their assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

context-techstack scope-quality type-improvement