Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable golangci-lint's default excluded issues #72

Closed
svengreb opened this issue Nov 21, 2021 · 0 comments · Fixed by #73
Closed

Disable golangci-lint's default excluded issues #72

svengreb opened this issue Nov 21, 2021 · 0 comments · Fixed by #73
Labels
context-techstack scope-quality type-improvement
Milestone
0.10.0

Comments

@svengreb
Copy link
Owner

svengreb commented Nov 21, 2021 •
edited
Loading

By default golangci-lint excludes specific issues (matches) that are known to be "annoying", but this also includes issues explicitly enabled by this template, e.g. the revive rule to check that exported function and methods always have a comment.
To prevent these issues to be found the default excludes will be disables through the issues.exclude-use-default configuration field.
@svengreb svengreb added this to the Next milestone Nov 21, 2021
@svengreb svengreb self-assigned this Nov 21, 2021
svengreb added a commit that referenced this issue Nov 21, 2021
@svengreb
Disable golangci-lint's default excluded issues
3bf0998 
By default golangci-lint [2] excludes specific issues (matches) that are
known to be "annoying", but this also included issues explicitly enabled
by this template, e.g. the revive [3] rule to check that exported
function and methods always have a comment [4].
To prevent these issues to be found the default excludes have been
disabled through the `issues.exclude-use-default` configuration field.

[1]: https://golangci-lint.run/usage/configuration/#config-file
[2]: https://golangci-lint.run
[3]: https://github.com/mgechev/revive
[4]: https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#exported

GH-72
@svengreb svengreb mentioned this issue Nov 21, 2021
Merged
svengreb added a commit that referenced this issue Nov 21, 2021
@svengreb
Disable golangci-lint's default excluded issues (#73)
c099c6e 
By default golangci-lint [2] excludes specific issues (matches) that are
known to be "annoying", but this also included issues explicitly enabled
by this template, e.g. the revive [3] rule to check that exported
function and methods always have a comment [4].
To prevent these issues to be found the default excludes have been
disabled through the `issues.exclude-use-default` configuration field.

[1]: https://golangci-lint.run/usage/configuration/#config-file
[2]: https://golangci-lint.run
[3]: https://github.com/mgechev/revive
[4]: https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#exported

Closes GH-72
@svengreb svengreb removed their assignment Nov 21, 2021
@svengreb svengreb mentioned this issue Nov 21, 2021
Closed
svengreb added a commit to svengreb/wand that referenced this issue Nov 21, 2021
@svengreb
Update to tmpl-go template repository version 0.10.0
efac76a 
Updated to `tmpl-go` version `0.10.0` [1] which...

1. disables `golangci-lint`'s default excluded issues [2] - this
   prevents that explicitly enabled rules are not ignored due to the
   default set of excluded issues.
2. caches Go dependencies and build outputs in `ci-go` workflow [3] -
   this improves the workflow execution time.

See the full `tmpl-go` version `0.10.0` changelog [1] for all details.

[1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.10.0
[2]: svengreb/tmpl-go#72
[3]: svengreb/tmpl-go#74

GH-110
svengreb added a commit to svengreb/wand that referenced this issue Nov 21, 2021
@svengreb
Update to tmpl-go template repository version 0.10.0 (#111)
ee52f08 
Updated to `tmpl-go` version `0.10.0` [1] which...

1. disables `golangci-lint`'s default excluded issues [2] - this
   prevents that explicitly enabled rules are not ignored due to the
   default set of excluded issues.
2. caches Go dependencies and build outputs in `ci-go` workflow [3] -
   this improves the workflow execution time.

See the full `tmpl-go` version `0.10.0` changelog [1] for all details.

[1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.10.0
[2]: svengreb/tmpl-go#72
[3]: svengreb/tmpl-go#74

Closes GH-110
@svengreb svengreb mentioned this issue May 9, 2022
Closed
svengreb added a commit to svengreb/nib that referenced this issue May 9, 2022
@svengreb
Update to tmpl-go template repository version 0.12.0
fef2e6a 
Updated to `tmpl-go` version 0.12.0 [1], including the versions in
between starting from 0.7.0 [3]:

1. Updated to Go 1.17 [4].
2. Updated to golangci-lint `v1.43.0` [5].
3. Updated to `tmpl` template repository version `0.11.0` [6].
4. Optimized GitHub action workflows for Go and Node [7].
5. Disabled golangci-lint's default excluded issues [8].
6. Introduced Go dependency caching and build outputs in `ci-go`
   workflow [9].
7. Disabled revive linter rule `package-comments` [10].
8. Fixed golangci-lint fail to run due to `revives` unknown `time-equal`
   rule [11].
9. updated Node.js packages & GitHub actions [12].

This also included changes required for any linter matches.

[1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.12.0
[3]: https://github.com/svengreb/tmpl-go/releases/tag/v0.7.0
[4]: svengreb/tmpl-go#66
[5]: svengreb/tmpl-go#64
[6]: svengreb/tmpl-go#91
[7]: svengreb/tmpl-go#68
[8]: svengreb/tmpl-go#72
[9]: svengreb/tmpl-go#74
[10]: svengreb/tmpl-go#78
[11]: svengreb/tmpl-go#76
[12]: svengreb/tmpl-go#42

GH-62
svengreb added a commit to svengreb/nib that referenced this issue May 9, 2022
@svengreb
Update to tmpl-go template repository version 0.12.0
797b5ba 
Updated to `tmpl-go` version 0.12.0 [1], including the versions in
between starting from 0.7.0 [3]:

1. Updated to Go 1.17 [4].
2. Updated to golangci-lint `v1.43.0` [5].
3. Updated to `tmpl` template repository version `0.11.0` [6].
4. Optimized GitHub action workflows for Go and Node [7].
5. Disabled golangci-lint's default excluded issues [8].
6. Introduced Go dependency caching and build outputs in `ci-go`
   workflow [9].
7. Disabled revive linter rule `package-comments` [10].
8. Fixed golangci-lint fail to run due to `revives` unknown `time-equal`
   rule [11].
9. updated Node.js packages & GitHub actions [12].

This also included changes required for any linter matches.

[1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.12.0
[3]: https://github.com/svengreb/tmpl-go/releases/tag/v0.7.0
[4]: svengreb/tmpl-go#66
[5]: svengreb/tmpl-go#64
[6]: svengreb/tmpl-go#91
[7]: svengreb/tmpl-go#68
[8]: svengreb/tmpl-go#72
[9]: svengreb/tmpl-go#74
[10]: svengreb/tmpl-go#78
[11]: svengreb/tmpl-go#76
[12]: svengreb/tmpl-go#42

GH-62
svengreb added a commit to svengreb/nib that referenced this issue May 9, 2022
@svengreb
Update to tmpl-go template repository version 0.12.0 (#63)
4890bd0 
Updated to `tmpl-go` version 0.12.0 [1], including the versions in
between starting from 0.7.0 [3]:

1. Updated to Go 1.17 [4].
2. Updated to golangci-lint `v1.43.0` [5].
3. Updated to `tmpl` template repository version `0.11.0` [6].
4. Optimized GitHub action workflows for Go and Node [7].
5. Disabled golangci-lint's default excluded issues [8].
6. Introduced Go dependency caching and build outputs in `ci-go`
   workflow [9].
7. Disabled revive linter rule `package-comments` [10].
8. Fixed golangci-lint fail to run due to `revives` unknown `time-equal`
   rule [11].
9. updated Node.js packages & GitHub actions [12].

This also included changes required for any linter matches.

[1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.12.0
[3]: https://github.com/svengreb/tmpl-go/releases/tag/v0.7.0
[4]: svengreb/tmpl-go#66
[5]: svengreb/tmpl-go#64
[6]: svengreb/tmpl-go#91
[7]: svengreb/tmpl-go#68
[8]: svengreb/tmpl-go#72
[9]: svengreb/tmpl-go#74
[10]: svengreb/tmpl-go#78
[11]: svengreb/tmpl-go#76
[12]: svengreb/tmpl-go#42

GH-62
@svengreb svengreb mentioned this issue May 10, 2022
Closed
svengreb added a commit to svengreb/golib that referenced this issue May 10, 2022
@svengreb
Update to tmpl-go template repository version 0.12.0
4f35b10 
Updated to `tmpl-go` version `0.12.0` [1], including the versions in
between starting from 0.7.0 [3]:

1. Updated to Go 1.17 [4].
2. Updated to golangci-lint `v1.43.0` [5].
3. Updated to `tmpl` template repository version `0.11.0` [6].
4. Optimized GitHub action workflows for Go and Node [7].
5. Disabled golangci-lint's default excluded issues [8].
6. Introduced Go dependency caching and build outputs in `ci-go`
   workflow [9].
7. Disabled revive linter rule `package-comments` [10].
8. Fixed golangci-lint fail to run due to `revives` unknown `time-equal`
   rule [11].
9. Updated Node.js packages & GitHub actions [12].

This also includes changes required for any linter matches.

[1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.12.0
[3]: https://github.com/svengreb/tmpl-go/releases/tag/v0.7.0
[4]: svengreb/tmpl-go#66
[5]: svengreb/tmpl-go#64
[6]: svengreb/tmpl-go#91
[7]: svengreb/tmpl-go#68
[8]: svengreb/tmpl-go#72
[9]: svengreb/tmpl-go#74
[10]: svengreb/tmpl-go#78
[11]: svengreb/tmpl-go#76
[12]: svengreb/tmpl-go#42

GH-41
svengreb added a commit to svengreb/golib that referenced this issue May 10, 2022
@svengreb
Update to tmpl-go template repository version 0.12.0 (#42)
5116546 
Updated to `tmpl-go` version `0.12.0` [1], including the versions in
between starting from 0.7.0 [3]:

1. Updated to Go 1.17 [4].
2. Updated to golangci-lint `v1.43.0` [5].
3. Updated to `tmpl` template repository version `0.11.0` [6].
4. Optimized GitHub action workflows for Go and Node [7].
5. Disabled golangci-lint's default excluded issues [8].
6. Introduced Go dependency caching and build outputs in `ci-go`
   workflow [9].
7. Disabled revive linter rule `package-comments` [10].
8. Fixed golangci-lint fail to run due to `revives` unknown `time-equal`
   rule [11].
9. Updated Node.js packages & GitHub actions [12].

This also includes changes required for any linter matches.

[1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.12.0
[3]: https://github.com/svengreb/tmpl-go/releases/tag/v0.7.0
[4]: svengreb/tmpl-go#66
[5]: svengreb/tmpl-go#64
[6]: svengreb/tmpl-go#91
[7]: svengreb/tmpl-go#68
[8]: svengreb/tmpl-go#72
[9]: svengreb/tmpl-go#74
[10]: svengreb/tmpl-go#78
[11]: svengreb/tmpl-go#76
[12]: svengreb/tmpl-go#42

GH-41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-techstack scope-quality type-improvement
Projects
None yet
Milestone
0.10.0
Development

Successfully merging a pull request may close this issue.

Disable golangci-lint's default excluded issues svengreb/tmpl-go
1 participant
@svengreb