-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: speed up CI a bit (hopefully) #9731
Conversation
|
ac80eb3
to
386d787
Compare
386d787
to
ebca0a5
Compare
ebca0a5
to
93a6f6b
Compare
is this ready? what's the tl;dr on what it's actually doing? |
As I recall, I had several points of feedback that weren't addressed yet. I don't know if @gtm-nayan still wants to continue with this or not? If not, perhaps we can split the flakiness fixes out into a new PR and close this one as I'm not sure we want to merge everything that was in this one though my memory of it could be outdated |
packages/kit/test/apps/basics/test/cross-platform/client.test.js
Outdated
Show resolved
Hide resolved
I removed some of the parts I was less sure of to unblock this and get the rest in. Feel free to resend those parts in a new PR with some more explanation |
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.