Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: speed up CI a bit (hopefully) #9731

Merged
merged 31 commits into from
Jul 14, 2024
Merged

chore: speed up CI a bit (hopefully) #9731

merged 31 commits into from
Jul 14, 2024

Conversation

gtm-nayan
Copy link
Contributor

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2023

⚠️ No Changeset found

Latest commit: 6c5128c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gtm-nayan gtm-nayan force-pushed the experiment-time-ci branch from ac80eb3 to 386d787 Compare April 20, 2023 13:22
@gtm-nayan gtm-nayan force-pushed the experiment-time-ci branch from 386d787 to ebca0a5 Compare April 21, 2023 15:10
@gtm-nayan gtm-nayan force-pushed the experiment-time-ci branch from ebca0a5 to 93a6f6b Compare April 22, 2023 06:21
@Rich-Harris
Copy link
Member

is this ready? what's the tl;dr on what it's actually doing?

@benmccann
Copy link
Member

As I recall, I had several points of feedback that weren't addressed yet. I don't know if @gtm-nayan still wants to continue with this or not? If not, perhaps we can split the flakiness fixes out into a new PR and close this one as I'm not sure we want to merge everything that was in this one though my memory of it could be outdated

@benmccann
Copy link
Member

I removed some of the parts I was less sure of to unblock this and get the rest in. Feel free to resend those parts in a new PR with some more explanation

@benmccann benmccann merged commit f3d7a3a into main Jul 14, 2024
12 of 13 checks passed
@benmccann benmccann deleted the experiment-time-ci branch July 14, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants