Skip to content

Commit

Permalink
try moving cross platform tests to a separate step
Browse files Browse the repository at this point in the history
  • Loading branch information
gtm-nayan committed Apr 21, 2023
1 parent 3a8195d commit ebca0a5
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ jobs:
- run: pnpm install --frozen-lockfile
- run: pnpm playwright install ${{ matrix.e2e-browser }}
- run: pnpm test
- run: pnpm test:cross-platform:dev && pnpm test:cross-platform:build
env:
KIT_CROSS_PLATFORM_TEST: '1'
- name: Archive test results
if: failure()
shell: bash
Expand Down Expand Up @@ -101,6 +104,7 @@ jobs:
mode: 'build'
env:
KIT_E2E_BROWSER: ${{matrix.e2e-browser}}
KIT_CROSS_PLATFORM_TEST: '1'
steps:
- run: git config --global core.autocrlf false
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "monorepo for @sveltejs/kit and friends",
"private": true,
"scripts": {
"test": "pnpm test -r --filter=./packages/* --filter=!./packages/create-svelte",
"test": "pnpm test -r --aggregate-output --filter=./packages/* --filter=!./packages/create-svelte",
"test:cross-platform:dev": "pnpm run --dir packages/kit test:cross-platform:dev",
"test:cross-platform:build": "pnpm run --dir packages/kit test:cross-platform:build",
"test:vite-ecosystem-ci": "pnpm test --dir packages/kit",
Expand Down
7 changes: 6 additions & 1 deletion packages/kit/test/apps/basics/playwright.config.js
Original file line number Diff line number Diff line change
@@ -1 +1,6 @@
export { config as default } from '../../utils.js';
import { config } from '../../utils.js';

config.testIgnore =
process.env.CI && !process.env.KIT_CROSS_PLATFORM_TEST ? ['test/cross-platform/**'] : [];

export default config;

0 comments on commit ebca0a5

Please sign in to comment.