Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerfile #58

Merged
merged 6 commits into from
Apr 2, 2024
Merged

Add dockerfile #58

merged 6 commits into from
Apr 2, 2024

Conversation

Edgar-21
Copy link
Contributor

@Edgar-21 Edgar-21 commented Mar 26, 2024

Heavily inspired by a dockerfile shared by Shimwell here https://forum.coreform.com/t/trelis-in-docker/442/2.

Uses the miniconda docker image as the base (Debian Bullseye), found here https://hub.docker.com/r/continuumio/miniconda3. To use cubit, the image can be run interactively, and the license file copied to the appropriate location. Cubit works in terminal with the --no-graphics option and can be imported into python.

I expect it will need a couple additions for this to work with Github actions. I'll start looking at that documentation in the next few days, in the meantime wanted to get this posted to get some eyes on it sooner rather than later

fixes #57

@Edgar-21
Copy link
Contributor Author

perhaps this goes without saying but this will also need the parastell dependencies added, I was thinking about doing that with conda/mamba since that is how our install instructions are written

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Edgar-21 - we might want to consolidate the dependencies

dockerfile Outdated Show resolved Hide resolved
@gonuke gonuke linked an issue Mar 28, 2024 that may be closed by this pull request
@gonuke
Copy link
Member

gonuke commented Mar 29, 2024

We need to add the environment file here too.

@gonuke gonuke added this to the First OO version milestone Mar 29, 2024
@Edgar-21
Copy link
Contributor Author

Edgar-21 commented Apr 1, 2024

This has a conda environment named parastell_env. After adding the license and activating the environment, ExampleScript.py from the main branch will run to completion and generate the expected outputs, at least when I run it

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works for me. I have a few convenience suggestions.

dockerfile Outdated Show resolved Hide resolved
environment.yml Show resolved Hide resolved
dockerfile Show resolved Hide resolved
@gonuke
Copy link
Member

gonuke commented Apr 2, 2024

Thanks @Edgar-21 - this works for me

@gonuke gonuke merged commit b147453 into svalinn:oo_version Apr 2, 2024
@gonuke gonuke linked an issue Apr 3, 2024 that may be closed by this pull request
@gonuke gonuke mentioned this pull request Apr 3, 2024
@Edgar-21 Edgar-21 deleted the add_dockerfile branch April 19, 2024 22:03
connoramoreno pushed a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a docker image for testing that has a reasonable environment Add a first unit test
2 participants