chore: remove CPE benchmark and cleanup related code #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunya-ch
previously approved these changes
Jan 10, 2025
| # set validate item | ||
| item = dict() | ||
| item["pod"] = benchmark_filename | ||
| item["scenarioID"] = "" |
There was a problem hiding this comment.
we may consider remove scenarioID column or replace later once we have to a tool or a way to differentiate the scenario of the benchmark.
There was a problem hiding this comment.
sure will create an issue to track this
vprashar2929
force-pushed
the
cleanup-cpe
branch
from
7cd9b02 to
dd89d0b
Compare
vprashar2929
commented
Jan 14, 2025
src/kepler_model/cmd/main.py
Outdated
Comment on lines
1038
to
1040
| # Plot arguments | ||
| parser.add_argument("--target-data", type=str, help="Speficy target plot data (preprocess, estimate)") | ||
| parser.add_argument("--scenario", type=str, help="Speficy scenario") |
There was a problem hiding this comment.
@sunya-ch Forgot to remove these. Will again require your lgtm
sunya-ch
reviewed
Jan 15, 2025
| @@ -1035,10 +945,6 @@ def run(): | |||
| parser.add_argument("-fg", "--feature-group", type=str, help="Specify target feature group for energy estimation.", default="") | |||
| parser.add_argument("--model-name", type=str, help="Specify target model name for energy estimation.") | |||
|
|
|||
| # Plot arguments | |||
| parser.add_argument("--target-data", type=str, help="Speficy target plot data (preprocess, estimate)") | |||
There was a problem hiding this comment.
I think we need to keep #Plot arguments and --target-data (also would be nice to fix typo of Specify). It is used by plot command.
There was a problem hiding this comment.
my bad I thought it was related to plot_scenario func 😞
This commit removes the deployments and benchmark related to the CPE operator. It also cleans up the associated code and documentation. Signed-off-by: vprashar2929 <[email protected]>
vprashar2929
force-pushed
the
cleanup-cpe
branch
from
dd89d0b to
b210c67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the deployments and benchmark related to the CPE operator. It also cleans up the associated code and documentation.
Addresses #560
Checklist for PR Author
In addition to approval, the author must confirm the following check list:
Run the following command to format your code:
Create issues for unresolved comments and link them to this PR. Use one of the following labels:
must-fix: The logic appears incorrect and must be addressed.minor: Typos, minor issues, or potential refactoring for better readability.nit: Trivial issues like extra spaces, commas, etc.