Skip to content

Commit

Permalink
Merge pull request #571 from vprashar2929/cleanup-cpe
Browse files Browse the repository at this point in the history
chore: remove CPE benchmark and cleanup related code
  • Loading branch information
vprashar2929 authored Jan 15, 2025
2 parents 07c1c3e + b210c67 commit bd4c15c
Show file tree
Hide file tree
Showing 14 changed files with 31 additions and 1,702 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ OPTS="ESTIMATOR SERVER" make deploy
## Model Training

- [Use Tekton pipeline](./model_training/tekton/README.md)
- [Use Bash script with CPE operator](./model_training/cpe_script_instruction.md)

## Local test

Expand Down
7 changes: 0 additions & 7 deletions contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,6 @@ Learn more details about [model training](./model_training/)

### Introduce new benchmarks

The new benchmark must be supported by [CPE operator](https://github.com/IBM/cpe-operator) for automation.
Find [examples](https://github.com/IBM/cpe-operator/tree/main/examples).

### CPE-based (deprecated)

`Benchmark` CR has a dependency on `BenchmarkOperator`. Default `BechmarkOperator` is to support [batch/v1/Job API](https://github.com/IBM/cpe-operator/blob/main/examples/none/cpe_v1_none_operator.yaml).

### Tekton

Create workload `Task` and provide example `Pipeline` to run.
Expand Down
8 changes: 1 addition & 7 deletions model_training/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,17 +62,11 @@ Please confirm the following requirements:

### Run benchmark and collect metrics

There are two options to run the benchmark and collect the metrics, [CPE-operator](https://github.com/IBM/cpe-operator) with manual script and [Tekton Pipeline](https://github.com/tektoncd/pipeline).

> The adoption of the CPE operator is slated for deprecation. We are on transitioning to the automation of collection and training processes through the Tekton pipeline. Nevertheless, the CPE operator might still be considered for usage in customized benchmarks requiring performance values per sub-workload within the benchmark suite.
- [Tekton Pipeline Instruction](./tekton/README.md)

- [CPE Operator Instruction](./cpe_script_instruction.md)

### With manual execution

In addition to the above two automation approach, you can manually run your own benchmarks, then collect, train, and export the models by the entrypoint
In addition to the above approach, you can manually run your own benchmarks, then collect, train, and export the models by the entrypoint

[Manual Metric Collection and Training with Entrypoint](./cmd_instruction.md)

Expand Down
2 changes: 1 addition & 1 deletion model_training/cmd_instruction.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ PUBLISHER= # github account of publisher

### 3.1. Extracting collect date from benchmark file

The benchmark file is created by CPE operator or by query function from step 1.
The benchmark file is created query function from step 1.

```bash
# export execution
Expand Down
36 changes: 0 additions & 36 deletions model_training/cpe_benchmark/coremark.yaml

This file was deleted.

41 changes: 0 additions & 41 deletions model_training/cpe_benchmark/parsec.yaml

This file was deleted.

33 changes: 0 additions & 33 deletions model_training/cpe_benchmark/sample.yaml

This file was deleted.

Loading

0 comments on commit bd4c15c

Please sign in to comment.