feat: Introduce header based auth along with existing cookie based auth #262

KShivendu · 2022-12-05T03:37:01Z

Summary of change

Introduce header based auth along with existing cookie based auth

Related issues

Link to issue1 here
Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

Changelog has been updated
coreDriverInterfaceSupported.json file has been updated (if needed)
- Along with the associated array in supertokens_python/constants.py
frontendDriverInterfaceSupported.json file has been updated (if needed)
Changes to the version if needed
- In setup.py
- In supertokens_python/constants.py
Had installed and ran the pre-commit hook
Issue this PR against the latest non released version branch.
- To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
- If no such branch exists, then create one from the latest released branch.
If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py

Remaining TODOs for this PR

Item1
Item2

supertokens_python/framework/django/framework.py

supertokens_python/framework/flask/framework.py

supertokens_python/framework/fastapi/framework.py

supertokens_python/recipe/emailpassword/api/implementation.py

supertokens_python/recipe/emailverification/api/email_verify.py

supertokens_python/recipe/session/recipe_implementation.py

supertokens_python/recipe/session/session_functions.py

…before responding

supertokens_python/framework/flask/flask_response.py

supertokens_python/recipe/session/access_token.py

supertokens_python/recipe/session/constants.py

supertokens_python/recipe/session/cookie_and_header.py

supertokens_python/recipe/session/recipe_implementation.py

supertokens_python/recipe/session/session_class.py

supertokens_python/recipe/session/interfaces.py

supertokens_python/supertokens.py

supertokens_python/recipe/session/recipe_implementation.py

supertokens_python/recipe/session/__init__.py

supertokens_python/recipe/session/cookie_and_header.py

supertokens_python/recipe/session/framework/django/syncio/__init__.py

supertokens_python/recipe/session/utils.py

supertokens_python/recipe/session/session_class.py

supertokens_python/recipe/session/cookie_and_header.py

supertokens_python/recipe/session/recipe_implementation.py

supertokens_python/recipe/session/session_class.py

supertokens_python/recipe/session/recipe_implementation.py

porcellus

There is a FIXME comment still left over

supertokens_python/recipe/session/recipe_implementation.py

supertokens_python/supertokens.py

supertokens_python/recipe/session/recipe_implementation.py

porcellus

I think there may be test cases missing (the behavior table tests), but code changes are looking good to me.

…fer_method

tests/test_session.py

supertokens_python/recipe/session/recipe.py

supertokens_python/recipe/session/cookie_and_header.py

supertokens_python/recipe/session/recipe_implementation.py

tests/test_session.py

fix: Clear session changes for header based auth

The base branch was changed.

feat: Introduce header based auth along with existing cookie based auth

a25373a

rishabhpoddar suggested changes Dec 11, 2022

View reviewed changes

KShivendu added 3 commits December 13, 2022 18:26

fix: Pass partial functions to session object for modifying response …

ef4b24e

…before responding

fix: Remove repeated headers in flask auth and refactor logic

9d8aa9e

fix: Fix lint errors and refactor logic

50a6448

rishabhpoddar suggested changes Dec 15, 2022

View reviewed changes

refactor: Improve variables names and code quality

6826ff1

porcellus requested changes Dec 19, 2022

View reviewed changes

KShivendu added 4 commits December 22, 2022 22:03

Improve header based auth logic

13a3da7

fix: Type errors in tests because of signature updates

bb46a5e

refactor: Minor changes in session recipe suggested in feedback

f7af9d8

refactor: Use response mutators everywhere instead of new tokens info

f1657ff

porcellus requested changes Dec 28, 2022

View reviewed changes

refactor: Minor changes in header based auth logic

cfa29ac

porcellus requested changes Dec 29, 2022

View reviewed changes

fix: Fix mistake in create_new_session that failed tests

8cde45b

porcellus requested changes Dec 29, 2022

View reviewed changes

supertokens_python/recipe/session/recipe_implementation.py Outdated Show resolved Hide resolved

supertokens_python/supertokens.py Show resolved Hide resolved

supertokens_python/recipe/session/recipe_implementation.py Show resolved Hide resolved

test: Use cookie as token transfer method for existing tests

8f8c496

porcellus previously approved these changes Dec 29, 2022

View reviewed changes

KShivendu added 7 commits December 30, 2022 12:15

refactor: Changes for header based auth

0b06480

test: Fix failing tests because of IdRefreshToken and get_token_trans…

87cb08d

…fer_method

test: Remove IdRefreshToken from all the tests

107ea0e

fix: Missing use of unquote func for parsing cookie value

33e3362

test: Fix test failures and add more tests in test_auth_mode

63f0b63

tests: Fix and add new auth mode tests

3352bdc

test: Fix failing tests for revoke session during refresh

8581d84

KShivendu commented Jan 3, 2023

View reviewed changes

tests/test_session.py Outdated Show resolved Hide resolved

rishabhpoddar reviewed Jan 4, 2023

View reviewed changes

KShivendu added 2 commits January 5, 2023 13:48

refactor: Strongly type response mutators

185c950

refactor: Improve response mutators usage in handle_error

5048d89

refactor: Fix cyclic import error

b4809f2

rishabhpoddar suggested changes Jan 5, 2023

View reviewed changes

tests/test_session.py Show resolved Hide resolved

KShivendu and others added 10 commits January 5, 2023 17:25

Merge branch '0.11' into feat/header-based-auth

7bbcb53

Merge branch '0.11' into feat/header-based-auth

ed905b8

fix: Clear session changes for edge cases

1f161ef

chores: Update changelog to mention header based auth changes

fa22498

test: Fix issues with tests

11fca6d

chores: Run formatter

168450c

test: Restore get_st_init_args func params

6f1262f

test: Fix failing tests and use url decode for token cookies

e7f89c0

chores: Bump version to 0.12.0 with other relevant changes

92a1104

Merge pull request #275 from supertokens/fix/clear-sesion

4f2cccc

fix: Clear session changes for header based auth

rishabhpoddar changed the base branch from 0.11 to 0.12 February 1, 2023 12:52

rishabhpoddar merged commit 181f423 into 0.12 Feb 1, 2023

rishabhpoddar deleted the feat/header-based-auth branch February 1, 2023 12:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Introduce header based auth along with existing cookie based auth #262

feat: Introduce header based auth along with existing cookie based auth #262

KShivendu commented Dec 5, 2022 •

edited

Loading

porcellus left a comment

porcellus left a comment

feat: Introduce header based auth along with existing cookie based auth #262

feat: Introduce header based auth along with existing cookie based auth #262

Conversation

KShivendu commented Dec 5, 2022 • edited Loading

Summary of change

Related issues

Test Plan

Documentation changes

Checklist for important updates

Remaining TODOs for this PR

porcellus left a comment

Choose a reason for hiding this comment

porcellus left a comment

Choose a reason for hiding this comment

KShivendu commented Dec 5, 2022 •

edited

Loading