Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clear session changes for header based auth #275

Merged
merged 7 commits into from
Jan 23, 2023

Conversation

KShivendu
Copy link
Contributor

@KShivendu KShivendu commented Jan 11, 2023

Summary of change

Clear session changes and CHANGELOG

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py

@KShivendu KShivendu changed the base branch from feat/header-based-auth to 0.11 January 11, 2023 07:40
@KShivendu KShivendu changed the base branch from 0.11 to feat/header-based-auth January 11, 2023 07:40
tests/utils.py Outdated Show resolved Hide resolved
tests/Fastapi/test_fastapi.py Show resolved Hide resolved
tests/utils.py Outdated Show resolved Hide resolved
tests/Fastapi/test_fastapi.py Show resolved Hide resolved
Copy link
Collaborator

@porcellus porcellus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on slack, please check if access_token and access_token_from_header have the same encoding in extract_info I think access_token might be URL encoded.
Other than that it looks good.

@porcellus porcellus merged commit 4f2cccc into feat/header-based-auth Jan 23, 2023
@porcellus porcellus deleted the fix/clear-sesion branch January 23, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants