Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] add support for hinting via api/v_/instance preferred image / video max sizes #3505

Conversation

NyaaaWhatsUpDoc
Copy link
Member

Description

When left unset, defaults to local max size. The reason i didn't actually add local-image-max-size and local-video-max-size is in doing that it potentially opens us up for requiring local-audio-max-size, and potentially any other file types that we separate on in the future. It makes more sense to have a single local max size, and allow tweaking the frontend hinting that applications like Tusky use for autosizing.

It also updates the unused media limits (framerate, image / video dimensions) to just be the maximum possible int sizes. In case Tusky does try to limit based on those since we can support anything under the local max size.

closes #3449

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst tsmethurst merged commit f3b2eca into superseriousbusiness:main Nov 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Differentiate between video + image size limits again in configuration
2 participants