Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Differentiate between video + image size limits again in configuration #3449

Closed
tsmethurst opened this issue Oct 16, 2024 · 2 comments · Fixed by #3505
Closed

[feature] Differentiate between video + image size limits again in configuration #3449

tsmethurst opened this issue Oct 16, 2024 · 2 comments · Fixed by #3505
Labels
enhancement New feature or request

Comments

@tsmethurst
Copy link
Contributor

From the Matrix chat:

In previous versions we had media-image-max-size: 10MiB and media-video-max-size: 10MiB in config.yaml file. Now we have the same value regardless multimedia type. This value was useful for clients that automatically downscale big images to follow instance rules (ie. Tusky). Have you considered bringing it back?

I don't think any of us realized this but some clients (Tusky is great) used those sizes as targets to scale down images before uploading. Since this is a pretty cool feature, we could look at splitting up between local video + image size limits again.

@tsmethurst tsmethurst added the enhancement New feature or request label Oct 16, 2024
@NyaaaWhatsUpDoc
Copy link
Member

we definitely should keep the remote vs local distinction though. maybe add more granular image vs video just for local? would definitely be much simpler that way not requiring such fanangling in the media processing pipeline itself

@tsmethurst
Copy link
Contributor Author

Oh yeah the remote vs local should definitely stay, that's really useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants