-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👀 More featured and bugfixed action #61
Draft
JargeZ
wants to merge
13
commits into
superfly:main
Choose a base branch
from
JargeZ:unsafe-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JargeZ
force-pushed
the
unsafe-name
branch
7 times, most recently
from
August 21, 2024 06:34
6fa0a1a
to
e1cd01e
Compare
This reverts commit fdc5687.
JargeZ
force-pushed
the
unsafe-name
branch
5 times, most recently
from
September 4, 2024 03:08
6e91b07
to
f47aaa9
Compare
JargeZ
force-pushed
the
unsafe-name
branch
3 times, most recently
from
September 10, 2024 07:43
99de34c
to
c377247
Compare
JargeZ
changed the title
Pass build-args and custom app name to achieve in-sync multi-repository preview deploy
More featured and bugfixed action
Sep 10, 2024
JargeZ
changed the title
More featured and bugfixed action
👀 More featured and bugfixed action
Sep 10, 2024
JargeZ
force-pushed
the
unsafe-name
branch
3 times, most recently
from
October 25, 2024 00:43
bf750d8
to
d6ae3ae
Compare
This reverts commit 2045310.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally I created a pull request for one extension for my needs
However, since then I have added a lot of new things, so feel free to look, try, write comments and your feedback.
I use fly to preview applications, but it often happens that two repositories are linked to each other.For example, we have new functionality that affects the backend and frontend of the repository.To do this, I want to have a copy of the front-end preview-app that uses the corresponding base url of the back-end preview-app copy
I achieved this using a cross repository of reused workflowFrontend'sfly-rewiew.yaml
Backend'sfly-review.yaml
Thus, we use the branch name to synchronize the backend and frontend.To do this, the name of the branch must be the same in both repositories; usually this will be linked to a card from the task tracker.You can also pre-process the branch name to, for example, extract numbers and use only the Jira ticket number.I also think you can make an approach to build args as it was in pull request #50 and merge it before