Add --build-arg and --build-secret

[fredericrous]

fix #4

usage example

      - name: ✨ Deploy Preview
        uses: superfly/[email protected]
        with:
          build_args: |
            COMMIT_SHA=${{ github.sha }}
            OTHER_VARIABLE=true
          build_secrets: |
            SENTRY_AUTH_TOKEN=${{ secrets.SENTRY_AUTH_TOKEN }}

[pedroassumpcao]

This PR is great and fixes one of my needs as well.

[som-matrix]

if we add this option we don't need to pass dockerfile option explicitly anymore ?

[fredericrous]

I guess the answer to your question is yes. I don't have enough context to give you a straight forward good quality answer tho.
my use case is as follow:

I use build_args to set, inside the image, as an environment variable:

• the commit sha. I use this because I need to tell apart which sourcemap sent to Sentry correspond to which build
• a flag autosleep. My Remix server checks at runtime if that flag is there and if so it shuts itself down after a while in order to scale the fly machine down

build_secrets I use to set credentials needed by Sentry to upload the sourcemaps

and finally my dockerfile is the same for build and for production but the generated image is different in production than what's used for build because I make use of FROM more than once in the same dockerfile

FROM can appear multiple times within a single Dockerfile to create multiple images or use one build stage as a dependency for another. Simply make a note of the last image ID output by the commit before each new FROM instruction. Each FROM instruction clears any state created by previous instructions.

https://docs.docker.com/reference/dockerfile/#from

[som-matrix]

Got it , thanks

[suddenlyGiovanni]

This PR is great and fixes one of my needs as well.

I have a use case where I rely on a different npm package registry. It requires a token to operate (read), so I need to provide access to it when the docker images are built. I'm doing that by passing it as a "build_arg" to fly deploy.

This is something that I can do with superfly/flyctl-actions/setup-flyctl@master, but can't with superfly/[email protected]

Please, consider it.

[KrisCoulson]

Would also love to see this get merged. We have a similar problem needing build args for our frontend services and SHA for issue tracking. Currently we have a fork of this repository to add this functionality. Would love to just be able to use the official action.

[harrygr]

+1 to get this merged.

[ollebergkvist]

+1

[harrygr]

It looks like #69 adds the ability to set additional options for flyctl launch, which includes build-arg and build-secret.

I haven't tested it but it seems like it might solve the same problem that this PR is.

[fredericrous]

#69 adds the ability to update flyctl launch. Is there another PR that added the ability to update flyctl deploy?
this PR updates both

[harrygr]

Not that I've seen, but at least #69 looks like it allows setting build args for the initial review app, which in most cases should stay the same for the life of the app, given review apps are usually fairly short-lived