Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETHEREUM-CONTRACTS] more realistic fUSDC #2023

Merged
merged 3 commits into from
Sep 24, 2024
Merged

[ETHEREUM-CONTRACTS] more realistic fUSDC #2023

merged 3 commits into from
Sep 24, 2024

Conversation

d10r
Copy link
Collaborator

@d10r d10r commented Sep 23, 2024

  • new testnet deployments: fUSDC with 6 decimals
  • permit support

@d10r d10r linked an issue Sep 23, 2024 that may be closed by this pull request
[ETHEREUM-CONTRACTS DEVX] Shift fUSDC to 6 decimals #1853
Closed
@github-actions GitHub Actions
Copy link

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@d10r
Copy link
Collaborator Author

d10r commented Sep 23, 2024

permit support was already added in #1664, is available on newer testnets

@d10r d10r marked this pull request as ready for review September 23, 2024 16:06
@d10r d10r requested a review from hellwolf as a code owner September 23, 2024 16:06
@d10r d10r requested a review from a team as a code owner September 23, 2024 18:16
@d10r d10r linked an issue Sep 23, 2024 that may be closed by this pull request
[PROTOCOL-OPS] verification script failures go unnoticed #1654
Closed
@d10r
Copy link
Collaborator Author

d10r commented Sep 23, 2024 •
edited
Loading

piggy-backed fix for non-silent verification failure (#1654)

@d10r
Copy link
Collaborator Author

d10r commented Sep 23, 2024

Note regarding permit: the latest version 2.2 of FiatToken (USDC) added a variant of permit where the signature is just one parameter instead of 3. This has become common, but is non-standard (not as specified in https://eips.ethereum.org/EIPS/eip-2612).

@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.37%. Comparing base (3989df1) to head (d420092).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #2023   +/-   ##
=======================================
  Coverage   88.37%   88.37%           
=======================================
  Files         111      111           
  Lines        7001     7001           
  Branches      964      964           
=======================================
  Hits         6187     6187           
  Misses        812      812           
  Partials        2        2
Flag Coverage Δ
ethereum-contracts 94.51% <ø> (ø)
sdk-core 88.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hellwolf
hellwolf reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@hellwolf hellwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

I don't see the permit support?
Missing update of the changelog.

@d10r
Copy link
Collaborator Author

d10r commented Sep 24, 2024

  • I don't see the permit support?

    • Missing update of the changelog.

permit was already there, see comments.
no changelog update because only internal tooling changed.

@hellwolf
Copy link
Contributor

no changelog update because only internal tooling changed.

It is a change to the deploy-test-network flow, so adding a line in changelog wouldn't hurt for future reference.

hellwolf
hellwolf approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@hellwolf hellwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, keep squashing issues!

@hellwolf hellwolf merged commit 81e7c8d into dev Sep 24, 2024
24 checks passed
@hellwolf hellwolf deleted the fusdc_decimals branch September 24, 2024 10:14
@github-actions GitHub Actions
Copy link

XKCD Comic Relif

Link: https://xkcd.com/2023
https://xkcd.com/2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellwolf hellwolf hellwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ETHEREUM-CONTRACTS DEVX] Shift fUSDC to 6 decimals [PROTOCOL-OPS] verification script failures go unnoticed
2 participants
@d10r @hellwolf