Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ETHEREUM-CONTRACTS] Make TestToken support permit #1664

Merged
merged 1 commit into from
Sep 7, 2023
Merged

[ETHEREUM-CONTRACTS] Make TestToken support permit #1664

merged 1 commit into from
Sep 7, 2023

Conversation

0xdavinchee
Copy link
Contributor

  • inherit from OZ's ERC20Permit instead of just ERC20

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@0xdavinchee 0xdavinchee mentioned this pull request Sep 7, 2023
Closed
hellwolf
hellwolf approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@hellwolf hellwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good.

@hellwolf hellwolf added this pull request to the merge queue Sep 7, 2023
@hellwolf hellwolf removed this pull request from the merge queue due to a manual request Sep 7, 2023
@hellwolf hellwolf added this pull request to the merge queue Sep 7, 2023
Merged via the queue into dev with commit 00ff25b Sep 7, 2023
@hellwolf hellwolf deleted the test-token-permit-support branch September 7, 2023 15:45
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

XKCD Comic Relif

Link: https://xkcd.com/1664
https://xkcd.com/1664

@d10r d10r mentioned this pull request Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellwolf hellwolf hellwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xdavinchee @hellwolf