-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new Kakao Provider #834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @esinx, thanks for the PR, it would be great if you can provide a recording of some sort to show that this works (preferably via loom) and outline the steps needed to set this up. For example, it isn't immediately obvious where i should obtain the GOTRUE_EXTERNAL_KAKAO_CLIENT_ID
and GOTRUE_EXTERNAL_KAKAO_SECRET
from on the kakao developer portal.
Will post a loom within the next few days :) Thank you so much for reviewing this PR! |
Here's a loom of me retrieving a new client ID & secret from the kakao developers page! |
May I know when the kakao login feature will be available for supabase auth? I need Kakao Login for a project in progress, and I want to refer to it for my release plan. |
@kangmingtay I think this PR is ready to be reviewed-- is there an update on the feedbacks you left? I just pushed a sync that applies the project organization change(folder structure change). @igmyung |
hi @esinx, i think this is good to go! can you please merge in the master branch to fix the failing staticcheck and we can merge it in |
oh right, can you also do up some docs on how developers can use kakao as an oauth integration here (https://supabase.com/docs/guides/auth/overview#providers)? should be good as long as it's in the similar format as the rest! thanks @esinx ! |
My apologies for the delay. I just came back from my mandatory military service, and didn't have much time to go over the changes and the documentations. @hwr12, thank you for taking the time to complete the documentation! This PR took longer than I've expected due to my unavailability, but I really do appreciate the community effort in trying to complete this PR. Thank you @kangmingtay also for guiding us on how this PR should be made. Can't wait to see this feature make its way into supabase. Would be really amazing to have Kakao login available for all the Korean users out there. |
🎉 This PR is included in version 2.67.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
@kangmingtay |
Hi @hwr12, unfortunately not for now, the sign in with id token endpoint is still experimental but we can consider adding it in the future. We may also consider a webhook-based approach in the future which makes it easier to contribute oauth integrations to gotrue. |
@kangmingtay |
@hwr12 Can you explain why you are unable to use the |
@kangmingtay Becuase calling |
I've achieved such behavior through modifying the link generated by GoTrue. See https://github.com/esinx/RN-Kakao-Login-Gotrue |
Hi @esinx ! |
@hwr12 yup you are looking at the right code, and this code will allow you to open the login page using KakaoTalk's deep link. It's just how KakaoTalk works-- the app will handle any link under the host |
@esinx I am confused due to my lack of knowledge but after the login is handled on the Kakao Talk app, is the below code used to continue on signing in to supabase server? This code looks like doing it manually as I see refresh token and access token are used to set session. |
Hey everyone looking for the ID Token flow. First we need to finish #1108 and then we can add support for Kakao ID tokens. |
Thank you @hf . |
## What kind of change does this PR introduce? This PR adds 'kakao' to `Provider` type. Kakao provider was recently added to `supabase/gotrue` through this [PR](supabase/auth#834 has also been updated. [PR](supabase/supabase#14287)) ## What is the current behavior? IDE warns type error because there is no 'kakao' in `Provider` type. ![image](https://github.com/supabase/gotrue-js/assets/27193396/af8a4071-fc1e-4a3f-b019-3f92e49212dc) ## What is the new behavior? 'kakao' added properly in `Provider` type, so no error shown in IDE ## Additional context Please let me know if I have to change anything to be approved. Thank you!
Hi @hf @kangmingtay, I don't mean to bother you, but is there any update on the support for Kakao ID tokens? |
## What kind of change does this PR introduce? This PR adds Kakao(https://accounts.kakao.com/) as an external provider. ## What is the current behavior? This provider did not exist before. ## What is the new behavior? Based on Kakao developer docs(https://developers.kakao.com/), this PR creates a provider & test suite for Kakao external provider. ## Additional context Please let me know if there are any changes needed, I do acknowledge that this was once mentioned in another [comment](supabase#451 (comment)), but it seemed like the PR had been frozen since then. I wrote my own version to make sure the tests do pass and the features work properly. --------- Co-authored-by: Kang Ming <[email protected]>
## What kind of change does this PR introduce? This PR adds Kakao(https://accounts.kakao.com/) as an external provider. ## What is the current behavior? This provider did not exist before. ## What is the new behavior? Based on Kakao developer docs(https://developers.kakao.com/), this PR creates a provider & test suite for Kakao external provider. ## Additional context Please let me know if there are any changes needed, I do acknowledge that this was once mentioned in another [comment](supabase#451 (comment)), but it seemed like the PR had been frozen since then. I wrote my own version to make sure the tests do pass and the features work properly. --------- Co-authored-by: Kang Ming <[email protected]>
## What kind of change does this PR introduce? This PR adds Kakao(https://accounts.kakao.com/) as an external provider. ## What is the current behavior? This provider did not exist before. ## What is the new behavior? Based on Kakao developer docs(https://developers.kakao.com/), this PR creates a provider & test suite for Kakao external provider. ## Additional context Please let me know if there are any changes needed, I do acknowledge that this was once mentioned in another [comment](supabase#451 (comment)), but it seemed like the PR had been frozen since then. I wrote my own version to make sure the tests do pass and the features work properly. --------- Co-authored-by: Kang Ming <[email protected]>
What kind of change does this PR introduce?
This PR adds Kakao(https://accounts.kakao.com/) as an external provider.
What is the current behavior?
This provider did not exist before.
What is the new behavior?
Based on Kakao developer docs(https://developers.kakao.com/), this PR creates a provider & test suite for Kakao external provider.
Additional context
Please let me know if there are any changes needed, I do acknowledge that this was once mentioned in another comment, but it seemed like the PR had been frozen since then. I wrote my own version to make sure the tests do pass and the features work properly.