Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add kakao provider enum type #470

Merged
merged 1 commit into from
May 17, 2023
Merged

feat: Add kakao provider enum type #470

merged 1 commit into from
May 17, 2023

Conversation

hwr12
Copy link
Contributor

@hwr12 hwr12 commented May 17, 2023

What kind of change does this PR introduce?

Kakao auth provider sign in method has been added by this PR & doc
Kakao Auth PR
Kakao Auth docs PR
To support Kakao provider in the future releases in supabase-flutter, I have come up with this PR.

What is the current behavior?

No kakao provider option for Provider enum type
Please link any relevant issues here.

What is the new behavior?

Kakao provider option for Provider enum type

Additional context

If there's other changes needed, please let me know.

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@dshukertjr dshukertjr merged commit 9a1bb33 into supabase:main May 17, 2023
@hwr12
Copy link
Contributor Author

hwr12 commented May 17, 2023

Hi Tyler @dshukertjr ,
Thanks for approving my PR!
Just wondering if I want to login from flutter app with this package using Kakao talk app at first hand not through the web login page, maybe implementing loginWithKakaoTalk() method from flutter_kakao_sdk would be helpful?
Or is this package only support login from web browser?

@dshukertjr
Copy link
Member

@hwr12
The auth server of Supabase currently only supports web based OAuth sign in for all providers other than Apple and Google, but if you could leave a sample code for implementing native kakao login, that might be helpful for us to implement it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants