Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't throw error in exchangeCodeForSession #946

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! Should help with and potentially close a few issues

@kangmingtay kangmingtay merged commit 6e161ec into master Aug 27, 2024
4 checks passed
@kangmingtay kangmingtay deleted the km/handle-error branch August 27, 2024 18:22
kangmingtay pushed a commit that referenced this pull request Aug 30, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
🤖 I have created a release *beep* *boop*
---


##
[2.65.0](v2.64.4...v2.65.0)
(2024-08-27)


### Features

* add bindings for Multi-Factor Authentication (Phone)
([#932](#932))
([b957c30](b957c30))
* add kakao to sign in with ID token
([#845](#845))
([e2337ba](e2337ba))
* remove session, emit `SIGNED_OUT` when JWT `session_id` is invalid
([#905](#905))
([db41710](db41710))


### Bug Fixes

* Correct typo in GoTrueClient warning message
([#938](#938))
([8222ee1](8222ee1))
* don't throw error in exchangeCodeForSession
([#946](#946))
([6e161ec](6e161ec))
* move docker compose to v2
([#940](#940))
([38eef89](38eef89))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exchangeCodeForSession throws error instead of returning
2 participants