Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct typo in GoTrueClient warning message #938

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

fizal619
Copy link
Contributor

@fizal619 fizal619 commented Aug 3, 2024

What kind of change does this PR introduce?

This PR corrects the spelling of clock in a warning message in GoTrueClient.ts.

What is the current behavior?

@supabase_supabase-js.js?v=12ace510:5329 @supabase/gotrue-js: Session as retrieved from URL was issued in the future? Check the device clok for skew 

What is the new behavior?

@supabase_supabase-js.js?v=12ace510:5329 @supabase/gotrue-js: Session as retrieved from URL was issued in the future? Check the device clock for skew 

Additional context

image

J0
J0 previously approved these changes Aug 4, 2024
@J0 J0 dismissed their stale review August 5, 2024 11:29

Hey Sorry do you mind pulling in master and updating the branch? The tests should pass after.

@J0
Copy link
Contributor

J0 commented Aug 5, 2024

Thanks for the contribution! And sorry for the trouble - we use latest and the CI break is caused by the removal of Docker Compose v1 from the Ubuntu latest image I think

@fizal619
Copy link
Contributor Author

fizal619 commented Aug 9, 2024

All updated @J0

@fizal619 fizal619 requested a review from J0 August 12, 2024 20:49
@J0
Copy link
Contributor

J0 commented Aug 12, 2024

Thanks for the contribution

@J0 J0 merged commit 8222ee1 into supabase:master Aug 12, 2024
2 checks passed
kangmingtay pushed a commit that referenced this pull request Aug 30, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.65.0](v2.64.4...v2.65.0)
(2024-08-27)


### Features

* add bindings for Multi-Factor Authentication (Phone)
([#932](#932))
([b957c30](b957c30))
* add kakao to sign in with ID token
([#845](#845))
([e2337ba](e2337ba))
* remove session, emit `SIGNED_OUT` when JWT `session_id` is invalid
([#905](#905))
([db41710](db41710))


### Bug Fixes

* Correct typo in GoTrueClient warning message
([#938](#938))
([8222ee1](8222ee1))
* don't throw error in exchangeCodeForSession
([#946](#946))
([6e161ec](6e161ec))
* move docker compose to v2
([#940](#940))
([38eef89](38eef89))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants