Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require psych in Rakefile to avoid syck error when compiling gem #3

Closed
wants to merge 1 commit into from

Conversation

foobacca
Copy link
Member

From memory I'm not sure psych is available in ruby 1.8. If so this should at least be wrapped in a version check.

@5long
Copy link
Contributor

5long commented Mar 26, 2013

Psych is not available in 1.8.

I made a different attempt in #16: just keep using Syck until either

  • 1.8 support is dropped

Or

  • Make Psych a hard dependency of sup

@gauteh
Copy link
Member

gauteh commented Mar 26, 2013

There is a similar case here: ruhoh/ruhoh.rb#77

I guess Psych is the future, could there be made a conditional dependency on it for <1.9.2?

Migrating to Psych might require some config-file updating.

Regards, gaute

@5long
Copy link
Contributor

5long commented Mar 27, 2013

+1 to migrate to Psych. But I'd like to postpone it until we figure out how to migrate config files properly(either via documentation or code, and ruling out all runtime differences, which would be tough). The current code base assumes only Syck is used. I think it's better to merge #16 to get a release soon.

@gauteh gauteh mentioned this pull request Mar 27, 2013
@gauteh
Copy link
Member

gauteh commented Mar 27, 2013

This one at least is not the right way to go ;)

@gauteh gauteh closed this Mar 27, 2013
gauteh pushed a commit to gauteh/sup that referenced this pull request Aug 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants