Conditionally require the psych gem. It's included in ruby 1.9.2 or better. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MrWerewolf just want to say I'm right there with you, I appreciate the fix and would love to get this merged in. My problem is just I needed to throughly test all the use-cases before I can pull this in. I'm sure I added the psych gem stuff plus this for a good reason. I just need to look at the commits, figure out the problem I was having and make sure everything is cool. Thanks for your patience... that psych gem and yaml support in general is turning out to be a pretty big pain in the ass. |
|
@plusjade let me know if there's anything I can do to help. |
plusjade
added a commit
that referenced
this pull request
Aug 26, 2012
Conditionally require the psych gem. It's included in ruby 1.9.2 or better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The psych library ships with Ruby 1.9.2 or greater. Unfortunately, it seems there is no way to conditionally add a dependency to
ruhoh.gemspec, so this solution attempts a compromise by removing the dependency in the gemspec and adding the conditional dependency for bundler's Gemfile. This means users with ruby 1.8.x will be prompted to manually install psych when they run ruhoh for the first time. I got the idea from this article.What motivates me to do this is to resolve #54 (at least partially). The latest 1.9.x RubyInstaller includes psych, so Windows users with a recent version of ruby will be able to install and run ruhoh without going through the trouble of hacking the psych gem in order to install it.