-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs #90
Fix docs #90
Conversation
Also adds some documentation.
- Fix the repr of enum_with_val, it should be transparent. - Allow metas on the associated constants in the enum_with_vals macro, most importantly allowing docs.
Also add a *few* TODOs.
Sorry this adds even more warnings :/
- Remove IWaitable::into_handle, it was unused. - Fix a few "result not use" warnings.
Kernel heap memory managementCurrently, if the kernel ever OOMs, this will lead to a panic. This is really not ideal. Unfortunately, we depend on a lot of Rust structures that make use of allocation (Arc, Vec, String...). Some of those have methods to customize OOM behavior (Vec and String have try_reserve), but some structures (like Arc) seem to be devoid of any function to avoid OOM. This comment was generated by todo based on a
|
gdt::get_main_iopb does not prevent creation of multiple mut ref.There's currently no guarantee that we don't create multiple &mut pointer to the IOPB region, which would cause undefined behavior. In practice, it should only be used by `i386::process_switch`, and as such, there is never actually two main_iopb active at the same time. Still, it'd be nicer to have safe functions to access the IOPB. This comment was generated by todo based on a
|
Don't panic in Session::reply if active_request is not set.Session::reply currently asserts that an active session is set. This assertion can be trivially triggered by userspace, by calling the reply_and_receive syscall with reply_target set to a Session that hasn't received any request. This comment was generated by todo based on a
|
Don't panic in Session::reply if active_request is not set.Session::reply currently asserts that an active session is set. This assertion can be trivially triggered by userspace, by calling the reply_and_receive syscall with reply_target set to a Session that hasn't received any request. This comment was generated by todo based on a
|
Don't panic in Session::reply if active_request is not set.Session::reply currently asserts that an active session is set. This assertion can be trivially triggered by userspace, by calling the reply_and_receive syscall with reply_target set to a Session that hasn't received any request. This comment was generated by todo based on a
|
Fixed. |
WIP, don't merge yet.