Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HandleTable::add_handle should error if the table is full. #106

Open
todo bot opened this issue Dec 22, 2018 · 0 comments
Open

HandleTable::add_handle should error if the table is full. #106

todo bot opened this issue Dec 22, 2018 · 0 comments
Assignees
Labels
project-kernel Related to the kernel todo 🗒️ Created by the todo bot type-bug Something isn't working
Milestone

Comments

@todo
Copy link

todo bot commented Dec 22, 2018

HandleTable::add_handle currently assumes that insertion will always succeed. It does not implement any handle count limitations present in Horizon/NX. Furthermore, if the handle table is completely filled (e.g. there are 2^32 handles), the function will infinite loop. And as if that wasn't enough: it doesn't technically guarantee a handle will not get reused.


https://github.com/roblabla42/KFS/blob/adee47274ba5c0dc0ef112ce8933becd63d3da77/kernel/src/process.rs#L259-L269


This issue was generated by todo based on a TODO comment in adee472 when #90 was merged. cc @roblabla.
@todo todo bot assigned roblabla Dec 22, 2018
@todo todo bot added the todo 🗒️ Created by the todo bot label Dec 22, 2018
@roblabla roblabla added type-bug Something isn't working project-kernel Related to the kernel labels Dec 23, 2018
@roblabla roblabla added this to the kfs-6 milestone Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project-kernel Related to the kernel todo 🗒️ Created by the todo bot type-bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant