-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lodash as a dependency #1507
Conversation
🦋 Changeset detectedLatest commit: aedee23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/8unshgBaCdYvPVefN2CFpweLibuB |
Codecov Report
@@ Coverage Diff @@
## canary #1507 +/- ##
==========================================
+ Coverage 92.42% 92.57% +0.15%
==========================================
Files 202 201 -1
Lines 4210 4216 +6
Branches 1353 1353
==========================================
+ Hits 3891 3903 +12
+ Misses 299 293 -6
Partials 20 20
|
43402e9
to
52ec86b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Thanks a lot for tackling this 🪶 Nice to see that we already had most of the helper functions we needed, too! Just left a few thoughts
Co-authored-by: Robin Métral <[email protected]>
Whoops, I thought auto-merge would wait for your review. Sorry, @robinmetral! |
😄 no worries, this looks great! 🎉 |
Purpose
Lodash is one of Circuit UI's larger dependencies. It doesn't support treeshaking out of the box1 and is included in some of the basic building blocks of Circuit UI, so most components bear its performance cost.
Since we will drop support for legacy browsers in Circuit UI v5, we're now able to replace Lodash with native browser APIs and a small set of utility functions.
Approach and changes
Definition of done
Footnotes
Requires the use of
babel-plugin-lodash
. ↩