-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate useStep and Step to TypeScript #1505
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/Evp317yNXChK9CMsPp6CqZGK6eHL |
🦋 Changeset detectedLatest commit: 42ce33a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## main #1505 +/- ##
=======================================
Coverage 92.33% 92.33%
=======================================
Files 201 202 +1
Lines 4213 4213
Branches 1321 1351 +30
=======================================
Hits 3890 3890
+ Misses 304 303 -1
- Partials 19 20 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌟
Addresses #516.
Purpose
When I started to remove the use of
lodash
in Circuit UI, I quickly found that it was used heavily in the step component and hook. I took the opportunity to migrate them over to TypeScript.Approach and changes
useStep
hook andStep
component to TypeScript. TheuseStep
hook now has the same default options as theStep
component (Carousel
componentDefinition of done